Skip to content

Conversation

pnkfelix
Copy link
Contributor

This PR migrates all of the remaining diagnostics in rustc_borrowck over to rustc_mir, exposing them for use by both AST-borrowck and MIR-borrowck.

This should hopefully resolve all remaining cases of diagnostic messages emitted from borrowck under -Z borrowck-mir without an origin annotation.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix pnkfelix added WG-compiler-nll T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Oct 10, 2017
@arielb1
Copy link
Contributor

arielb1 commented Oct 11, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 11, 2017

📌 Commit 5b68e1f has been approved by arielb1

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
@bors
Copy link
Collaborator

bors commented Oct 14, 2017

⌛ Testing commit 5b68e1f with merge 9c5e9a5...

bors added a commit that referenced this pull request Oct 14, 2017
…arielb1

MIR-borrowck: Migrate remaining ast diagnostics

This PR migrates all of the remaining diagnostics in `rustc_borrowck` over to `rustc_mir`, exposing them for use by both AST-borrowck and MIR-borrowck.

This should hopefully resolve all remaining cases of diagnostic messages emitted from borrowck under `-Z borrowck-mir` without an origin annotation.
@bors
Copy link
Collaborator

bors commented Oct 14, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing 9c5e9a5 to master...

@bors bors merged commit 5b68e1f into rust-lang:master Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants