Skip to content

Conversation

@alexcrichton
Copy link
Member

Some targets, like msp430 and nvptx, don't work with multiple codegen units
right now for bugs or fundamental reasons. To expose this allow targets to
express a default.

Closes #45000

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2017
@bors
Copy link
Collaborator

bors commented Oct 9, 2017

☔ The latest upstream changes (presumably #45035) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

r? @michaelwoerister

@bors
Copy link
Collaborator

bors commented Oct 9, 2017

☔ The latest upstream changes (presumably #45064) made this pull request unmergeable. Please resolve the merge conflicts.

@michaelwoerister
Copy link
Member

r=me with conflicts resolved.

Some targets, like msp430 and nvptx, don't work with multiple codegen units
right now for bugs or fundamental reasons. To expose this allow targets to
express a default.

Closes rust-lang#45000
@alexcrichton
Copy link
Member Author

@bors: r=michaelwoerister

@bors
Copy link
Collaborator

bors commented Oct 9, 2017

📌 Commit 5187763 has been approved by michaelwoerister

@bors
Copy link
Collaborator

bors commented Oct 11, 2017

⌛ Testing commit 5187763 with merge a5508d30e83ed5f6f9431d3c5590b7339e3c8d11...

@bors
Copy link
Collaborator

bors commented Oct 11, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

@bors retry

@bors
Copy link
Collaborator

bors commented Oct 13, 2017

⌛ Testing commit 5187763 with merge 43d95e2...

bors added a commit that referenced this pull request Oct 13, 2017
rustc: Allow target-specific default cgus

Some targets, like msp430 and nvptx, don't work with multiple codegen units
right now for bugs or fundamental reasons. To expose this allow targets to
express a default.

Closes #45000
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2017
@bors
Copy link
Collaborator

bors commented Oct 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 43d95e2 to master...

@bors bors merged commit 5187763 into rust-lang:master Oct 13, 2017
@alexcrichton alexcrichton deleted the target-cfu branch October 14, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants