Rollup of 5 pull requests #44791
Closed
Rollup of 5 pull requests #44791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Sep 23, 2017
GuillaumeGomez
commented
- Successful merges: Indicate how ChildStd{in,out,err} FDs are closed. #44625, Trim and document libc shim #44765, Update some minor dependencies #44785, Improve diagnostics when attempting to match tuple enum variant with struct pattern #44786, Fix warning position in rustdoc code blocks #44789
- Failed merges:
Also run `cargo update` for rustc as well
This is the name the `gcc` crate has moved to
…etMisdreavus
Indicate how ChildStd{in,out,err} FDs are closed.
Fixes rust-lang#41452.
Trim and document libc shim (hopefully) easy part of rust-lang#44515. r? @alexcrichton
…tsakis Update some minor dependencies * run `cargo update` * Update cargo submodule * Update to the `cc` crate from `gcc`
Improve diagnostics when attempting to match tuple enum variant with struct pattern
Adds an extra note as below to explain that a tuple pattern was probably intended.
```
error[E0026]: variant `X::Y` does not have a field named `data`
--> src/main.rs:18:16
|
18 | X::Y { data } => println!("The data is {}", data)
| ^^^^ variant `X::Y` does not have field `data`
error[E0027]: pattern does not mention field `0`
--> src/main.rs:18:9
|
18 | X::Y { data } => println!("The data is {}", data)
| ^^^^^^^^^^^^^ missing field `0`
|
= note: trying to match a tuple variant with a struct variant pattern
```
Solution for rust-lang#41314.
… r=QuietMisdreavus Fix warning position in rustdoc code blocks Before: <img width="1440" alt="screen shot 2017-09-23 at 14 07 08" src="https://user-images.githubusercontent.com/3050060/30773382-b9649288-a06f-11e7-94ec-faa3c3ed999b.png"> After: <img width="1440" alt="screen shot 2017-09-23 at 14 58 31" src="https://user-images.githubusercontent.com/3050060/30773384-bdfc9f3e-a06f-11e7-9030-9fb8a5308668.png"> r? @QuietMisdreavus
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10 |
|
📌 Commit 89c5c91 has been approved by |
|
⌛ Testing commit 89c5c91 with merge 9e412ddcbdf2b709ff39c8a3a50367979663247a... |
|
💔 Test failed - status-travis |
|
I have no idea what went wrong in here... Let's give it another try... @bors: retry |
|
Ok, I'll just close it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.