add a lowercase suggestion to unknown_lints

[llogiq]

I recently wrote some tests for a clippy lint, copied the (uppercase) lint name into my test file and forgot to toggle the case. This PR adds a suggestion that would have saved me 10 minutes of debugging, so it's likely a net win 🙂 . Also it adds a UI test for the unknown_lints lint.

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[eddyb]

r? @nikomatsakis Did someone add a check for "suggestion" in @rust-highfive to assign me?!

[nikomatsakis]

Feels like a rather niche use case, but it's only a few lines of code, so... probably fine. Still, let's at least clean up the tests a bit.

[nikomatsakis]

I would expect to see this be #[allow(FOO_BAR)], to show that the suggestion does not fire for nonsense lints...is there a reason you chose foo_bar?

[llogiq]

This is testing the default behavior as a baseline.

[nikomatsakis]

Can you add a comment explaining the purpose of this test is to test the "lint case" suggestion?

[llogiq]

Will do.

[llogiq]

I will re-jiggle the tests and add some comments when I get to my PC.

[nikomatsakis]

@bors r+

[bors]

📌 Commit fa6c605 has been approved by nikomatsakis

[bors]

⌛ Testing commit fa6c605e00a72790ae6a34dc811a08262de6a548 with merge b26980dfb2223bcd2e23fcdefaee8816a6d3724b...

[bors]

💔 Test failed - status-travis

[kennytm]

The line numbers are wrong.

-warning: unknown lint: `foo_bar`
-  --> $DIR/not_found.rs:11:9
+warning: unknown lint: `FOO_BAR`
+  --> $DIR/not_found.rs:14:9
    |
 14 | #[allow(FOO_BAR)]
    |         ^^^^^^^
    |
    = note: #[warn(unknown_lints)] on by default
 
 warning: unknown lint: `DEAD_CODE`
-  --> $DIR/not_found.rs:12:8
+  --> $DIR/not_found.rs:16:8
    |
 16 | #[warn(DEAD_CODE)]
    |        ^^^^^^^^^ help: lowercase the lint name: `dead_code`
 
 warning: unknown lint: `Warnings`
-  --> $DIR/not_found.rs:13:8
+  --> $DIR/not_found.rs:18:8
    |
 18 | #[deny(Warnings)]
    |        ^^^^^^^^ help: lowercase the lint name: `warnings`

[llogiq]

Yeah, sorry about that. Me, at a bus stop, with slow, intermittent 3G connection trying to fake compiletest (because rustbuild doesn't like connection timeouts). Let's try that again.

[nikomatsakis]

Travis gives this result:

[00:40:37]  warning: unknown lint: `FOO_BAR`

[00:40:37] -  --> $DIR/not_found.rs:11:9

[00:40:37] +  --> $DIR/not_found.rs:14:9

[00:40:37]     |

[00:40:37]  14 | #[allow(FOO_BAR)]

[00:40:37]     |         ^^^^^^^

[00:40:37]     |

[00:40:37]     = note: #[warn(unknown_lints)] on by default

[00:40:37]  

[00:40:37]  warning: unknown lint: `DEAD_CODE`

[00:40:37]    --> $DIR/not_found.rs:16:8

[00:40:37]     |

[00:40:37]  16 | #[warn(DEAD_CODE)]

[00:40:37]     |        ^^^^^^^^^ help: lowercase the lint name: `dead_code`

[00:40:37]  

[00:40:37]  warning: unknown lint: `Warnings`

[00:40:37]    --> $DIR/not_found.rs:18:8

[00:40:37]     |

[00:40:37]  18 | #[deny(Warnings)]

[00:40:37]     |        ^^^^^^^^ help: lowercase the lint name: `warnings`

[llogiq]

What the git? I wanted to rebase this with the first comment, not with the stuff you see there. At least the tests no longer fail.

[llogiq]

@nikomatsakis sorry for wasting your time and thank you for the thorough review. I only fixed the commit message, the tests should run through as is.

[nikomatsakis]

@bors r+

[bors]

📌 Commit ba643fa has been approved by nikomatsakis

[nikomatsakis]

@llogiq not to worry! travis looks green now =)

[bors]

⌛ Testing commit ba643fa with merge 34e6788ba1edd310e5e66371f592fe9c1b744a03...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry

• Travis osx weirdness

[bors]

⌛ Testing commit ba643fa with merge efceda2...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing efceda2 to master...