Skip to content

Better timestamps in builds #42958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2017
Merged

Better timestamps in builds #42958

merged 2 commits into from
Jun 29, 2017

Conversation

@aidanhs
Copy link
Contributor

@aidanhs aidanhs commented Jun 28, 2017

@aidanhs aidanhs force-pushed the aphs-better-stamping branch from 7608b0a to 9ddee5f Compare June 28, 2017 22:10
Mark-Simulacrum
Mark-Simulacrum requested changes Jun 28, 2017
View reviewed changes
.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to have a comment here explaining this. I'd also like to note that comparing these two may be hard because of timezones (maybe there's something we can pass to date?).

I also think it may be worth printing this once before we run the script and afterwards -- that way we if we do find a problem, we know whether it happened during the build.

$ date && curl -s --head https://google.com | grep ^Date: | sed 's/Date: //g'
Wed Jun 28 16:24:07 MDT 2017
Wed, 28 Jun 2017 22:24:07 GMT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment, also justifying why timezones don't matter (relative differences give all the info we need).

I'm not confused by you suggesting printing before the script and afterwards - that's what it currently does, per the identical lines above and below the stamp line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes I missed that it already logs before and after. Looks good to me, thanks for doing this!

@aidanhs aidanhs force-pushed the aphs-better-stamping branch from 9ddee5f to 4097ed5 Compare June 28, 2017 22:34
@aidanhs aidanhs force-pushed the aphs-better-stamping branch from 4097ed5 to 984e764 Compare June 28, 2017 22:36
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2017

📌 Commit 984e764 has been approved by Mark-Simulacrum

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 29, 2017
@frewsxcv
Rollup merge of rust-lang#42958 - aidanhs:aphs-better-stamping, r=Mar…
aa63ec0 
…k-Simulacrum

Better timestamps in builds

r? @Mark-Simulacrum
@frewsxcv frewsxcv mentioned this pull request Jun 29, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Jun 29, 2017
Rollup merge of rust-lang#42958 - aidanhs:aphs-better-stamping, r=Mar…
d3329d7 
…k-Simulacrum

Better timestamps in builds

r? @Mark-Simulacrum
@arielb1 arielb1 mentioned this pull request Jun 29, 2017
Merged
bors added a commit that referenced this pull request Jun 29, 2017
@bors
Auto merge of #42964 - arielb1:rollup, r=arielb1
7acce37 
Rollup of 12 pull requests

- Successful merges: #42219, #42831, #42832, #42884, #42886, #42901, #42919, #42920, #42946, #42953, #42955, #42958
- Failed merges:
@bors bors merged commit 984e764 into rust-lang:master Jun 29, 2017
@aidanhs aidanhs deleted the aphs-better-stamping branch July 14, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidanhs @Mark-Simulacrum @bors