Skip to content

Rollup of 7 pull requests #42494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 7, 2017
Merged

Rollup of 7 pull requests #42494

merged 21 commits into from
Jun 7, 2017

Conversation

@frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jun 7, 2017

bjorn3 and others added 21 commits June 3, 2017 18:18
@bjorn3
Better docs for librustc/hir/def.rs
83e106a
@bjorn3
Add single doc comment to librustc/hir/def_id.rs
8df5dfb
@bjorn3
Doc comments for librustc/hir/lowering.rs
472199e
@bjorn3
Remove leftover? of old code
6f8426a
@bjorn3
Add doc comments to librustc/infer/region_inference/mod.rs
a555d49
@stephen-lazaro
Remove 'elided' from lifetime resolution error
7ed771f 
Removes 'elided' from lifetime resolution errors
Removes 'elided' from relevant error messaging tests
@bjorn3
Update def.rs
a9c2cdc
@bjorn3
Update lowering.rs
d1bdcbc
@bjorn3
Update mod.rs
949b2a3
@venkatagiri
rustc_llvm: re-run build script if config.toml changes
40f8536
@king6cong
doc rewording
018722e
@citizen428
Doc changes for assert macros
867ed2e 
See rust-lang#29381
@wesleywiser
syntax_pos::Symbol should not implement Sync
c47df30 
Fixes rust-lang#42407
@Mark-Simulacrum
Skip printing for skipped doc tests.
bc8fabb
@frewsxcv
Rollup merge of rust-lang#42409 - bjorn3:patch-3, r=frewsxcv
e702b75 
Better docs

Working on more doc improvements

Edit: done for today
@frewsxcv
Rollup merge of rust-lang#42415 - stephen-lazaro:Issue29094, r=arielb1
915b19d 
Remove 'elided' from lifetime resolution error

Removes 'elided' from lifetime resolution errors
Removes 'elided' from relevant error messaging tests

This PR resolves rust-lang#29094

r? @Mark-Simulacrum
@frewsxcv
Rollup merge of rust-lang#42429 - venkatagiri:llvm_config, r=alexcric…
b472b66 
…hton

rustc_llvm: re-run build script if config.toml changes

closes rust-lang#35199
@frewsxcv
Rollup merge of rust-lang#42438 - king6cong:master, r=alexcrichton
9e8c94c 
doc rewording
@frewsxcv
Rollup merge of rust-lang#42466 - wesleywiser:fix_42407, r=arielb1
bedead2 
syntax_pos::Symbol should not implement Sync

Fixes rust-lang#42407
@frewsxcv
Rollup merge of rust-lang#42469 - citizen428:document-assert-macros, …
7f8467e 
…r=steveklabnik

Doc changes for assert macros

See rust-lang#29381
@frewsxcv
Rollup merge of rust-lang#42485 - Mark-Simulacrum:skip-no-doc, r=alex…
24f48d0 
…crichton

Skip printing for skipped doc tests.

Followup to rust-lang#42437 to further reduce noise.

r? @alexcrichton
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Contributor Author

frewsxcv commented Jun 7, 2017

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Jun 7, 2017

📌 Commit 24f48d0 has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Jun 7, 2017

⌛ Testing commit 24f48d0 with merge f73f675...

bors added a commit that referenced this pull request Jun 7, 2017
@bors
Auto merge of #42494 - frewsxcv:rollup, r=frewsxcv
f73f675 
Rollup of 7 pull requests

- Successful merges: #42409, #42415, #42429, #42438, #42466, #42469, #42485
- Failed merges:
@bors
Copy link
Collaborator

bors commented Jun 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing f73f675 to master...

@bors bors merged commit 24f48d0 into rust-lang:master Jun 7, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelix pnkfelix

Labels

rollup A PR which is a rollup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.