Skip to content

Update release notes for 1.17 #41548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2017
Merged

Update release notes for 1.17 #41548

merged 1 commit into from
May 10, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 26, 2017

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

KiChjang
KiChjang reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: subtyping

Mark-Simulacrum
Mark-Simulacrum reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see Cell::swap, Cell::replace, Cell::into_inner, and Cell::take at all in the stable documentation. That's suspicious to me, since it feels like it was then stabilized within less than a cycle; perhaps unintentionally? I'm not sure. I don't know what the procedure around minor library stabilizations is, either. The other stabilized APIs are in the stable documentation, which is why I bring this up.

Copy link
Member

@kennytm kennytm Apr 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Simulacrum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Simulacrum afaict that is the case. These were stabilized within a single cycle.

SimonSapin
SimonSapin reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the linked PR it looks like only the constructors of such structs are private, the types are still public (assuming pub struct …)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch.

kevinmehall
kevinmehall reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the "skipping runtime-internal stack frames" part reverted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it.

kevinmehall
kevinmehall reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ICES -> ICEs

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 26, 2017
@alexcrichton
Copy link
Member

r=me when this is good to go

arielb1
arielb1 reviewed Apr 26, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the same as #32330.

@aidanhs aidanhs added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 26, 2017
@brson
Copy link
Contributor Author

brson commented Apr 26, 2017

Updated.

@CryZe
Copy link
Contributor

CryZe commented Apr 27, 2017

{Arc/Rc}::ptr_eq got stabilized with 1.17 too: https://doc.rust-lang.org/beta/std/rc/struct.Rc.html#method.ptr_eq

@brson
Copy link
Contributor Author

brson commented Apr 27, 2017

Thanks @CryZe. Updated.

@alexcrichton
Copy link
Member

@brson was this waiting on anything else? Or is this ready to go?

@carols10cents
Copy link
Member

Hm one of the travis jobs is marked as cancelled after 45 min 32 sec? Is that a timeout? I'm retrying it within travis...

@brson
Copy link
Contributor Author

brson commented May 9, 2017

Nah this is done.

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2017

📌 Commit 8e97693 has been approved by brson

@bors
Copy link
Collaborator

bors commented May 9, 2017

⌛ Testing commit 8e97693 with merge db1c9eb...

bors added a commit that referenced this pull request May 9, 2017
@bors
Auto merge of #41548 - brson:relnotes, r=brson
db1c9eb 
Update release notes for 1.17

[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md).

cc @steveklabnik
@bors
Copy link
Collaborator

bors commented May 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing db1c9eb to master...

@bors bors merged commit 8e97693 into rust-lang:master May 10, 2017
@brson brson mentioned this pull request May 10, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 10, 2017
bors added a commit that referenced this pull request May 11, 2017
@bors
Auto merge of #41899 - brson:backports, r=alexcrichton
4978d58 
[beta] backports

- #41666
- #41578
- #41548
- #41529

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@SimonSapin SimonSapin SimonSapin left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

+3 more reviewers

@kevinmehall kevinmehall kevinmehall left review comments

@arielb1 arielb1 arielb1 left review comments

@KiChjang KiChjang KiChjang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.