Skip to content

Conversation

eugene-bulkin
Copy link

Add/update docs for the ascii module per #29341.

r? @steveklabnik

Eugene Bulkin added 2 commits April 1, 2017 00:07
* Change `utf8` variable names to `non_ascii` to be more clear, since
ASCII and UTF-8 are compatible.

* Fix `EscapeDefault` struct description to follow the typical iterator
method format with a link to the generating function.

* Add more `escape_default` examples to cover every case mentioned in
the function description itself.
@eugene-bulkin
Copy link
Author

I wasn't entirely sure what else to say for the module-level docs. Feel free to suggest something that's more useful if you think mine aren't helpful enough! :)

@frewsxcv frewsxcv added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Apr 1, 2017
@frewsxcv
Copy link
Contributor

frewsxcv commented Apr 2, 2017

This looks great, thanks so much!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 2, 2017

📌 Commit a5d775d has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
API Docs: ascii

Add/update docs for the `ascii` module per rust-lang#29341.

r? @steveklabnik
bors added a commit that referenced this pull request Apr 5, 2017
@bors bors merged commit a5d775d into rust-lang:master Apr 5, 2017
@eugene-bulkin eugene-bulkin deleted the ascii-docs branch April 6, 2017 00:29
@chordowl chordowl mentioned this pull request Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants