macros: fix ICE on certain sequence repetitions #39730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
added
beta-nominated
|
This is a minimal reversion back to stable's behavior for backporting, details in #39709 (comment). |
|
@bors: r+ |
|
📌 Commit b3d7399 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
macros: fix ICE on certain sequence repetitions Fixes rust-lang#39709. r? @nrc
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
macros: fix ICE on certain sequence repetitions Fixes rust-lang#39709. r? @nrc
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
macros: fix ICE on certain sequence repetitions Fixes rust-lang#39709. r? @nrc
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
macros: fix ICE on certain sequence repetitions Fixes rust-lang#39709. r? @nrc
bors
added a commit
that referenced
this pull request
Feb 14, 2017
brson
added
the
beta-accepted
|
Accepted for beta. Picks cleanly. ICEs bad. |
Merged
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 2, 2017
[beta] next - #39913 - #39730 - #39674 - #39602 - #39586 - #39471 - #39980 - #40020 - #40135 @nikomatsakis [this commit](3787d33) did not pick cleanly. You might peek at it. I took the liberty of accepting all the nominations myself, but the [packed struct alignment](#39586) PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler. cc @alexcrichton
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39709.
r? @nrc