libbacktrace: Fix uninitialized variable #39509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Nice find! |
|
📌 Commit d14b268 has been approved by |
|
Nominating for a beta backport |
alexcrichton
added
beta-nominated
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
libbacktrace: Fix uninitialized variable Fixes rust-lang#39468
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
libbacktrace: Fix uninitialized variable Fixes rust-lang#39468
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 5, 2017
libbacktrace: Fix uninitialized variable Fixes rust-lang#39468
|
Accepted for backport in libs triage today |
alexcrichton
added
the
beta-accepted
brson
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Feb 11, 2017
alexcrichton
added a commit
to alexcrichton/libbacktrace
that referenced
this pull request
Jul 25, 2017
In rust-lang/rust#39468 it was discovered that this could cause a crash in libbacktrace due to freeing uninitialized memory, and this specific instance was fixed in rust-lang/rust#39509
dscho
pushed a commit
to dscho/libbacktrace
that referenced
this pull request
Jul 18, 2022
In rust-lang/rust#39468 it was discovered that this could cause a crash in libbacktrace due to freeing uninitialized memory, and this specific instance was fixed in rust-lang/rust#39509
johnsonjh
added a commit
to johnsonjh/libbacktrace
that referenced
this pull request
Oct 18, 2022
… of uninitialized bytes in pecoff.c; 3) Fix a use of undefined memory in pecoff.c 1) Note: as we target MINGW here, we still want to look up the symbols via the DWARF method (the native Windows way would be to call the SymFromAddr() function, but that would require .pdb files which MINGW does not produce). Signed-off-by: Johannes Schindelin <[email protected]> 2) This updates the local declaration of `str_size` to always be 4 bytes instead of platform-dependent as its initialization later on only fills in 4 bytes instead of all the bytes of `size_t`. Originally reported as rust-lang/rust#28447 this was fixed in rust-lang/rust#30908 3) In rust-lang/rust#39468 it was discovered that this could cause a crash in libbacktrace due to freeing uninitialized memory, and this specific instance was fixed in rust-lang/rust#39509
dscho
pushed a commit
to dscho/libbacktrace
that referenced
this pull request
Apr 8, 2024
In rust-lang/rust#39468 it was discovered that this could cause a crash in libbacktrace due to freeing uninitialized memory, and this specific instance was fixed in rust-lang/rust#39509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39468