Skip to content

Conversation

frewsxcv
Copy link
Contributor

No description provided.

@frewsxcv
Copy link
Contributor Author

r? @GuillaumeGomez

@@ -77,6 +82,9 @@ pub trait AsciiExt {
/// assert_eq!('A', ascii.to_ascii_uppercase());
/// assert_eq!('❤', utf8.to_ascii_uppercase());
/// ```
///
/// [`make_ascii_uppercase`]: #tymethod.make_ascii_uppercase
/// [`str::to_uppercase`]: .../primitive.str.html#method.to_uppercase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"..."? ;)

@@ -96,6 +109,9 @@ pub trait AsciiExt {
/// assert_eq!('a', ascii.to_ascii_lowercase());
/// assert_eq!('❤', utf8.to_ascii_lowercase());
/// ```
///
/// [`make_ascii_lowercase`]: #tymethod.make_ascii_lowercase
/// [`str::to_lowercase`]: .../primitive.str.html#method.to_lowercase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"..."

@GuillaumeGomez
Copy link
Member

Nice idea! r=me once urls fixed.

@frewsxcv
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

📌 Commit d896a0c has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

⌛ Testing commit d896a0c with merge 965b698...

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Contributor Author

@bors r+

🤖 🙅‍♂️

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: better comment wording #39238

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

📌 Commit d896a0c has been approved by frewsxcv

@frewsxcv
Copy link
Contributor Author

@bors r=GuillaumeGomez

Woops, didn't mean to r+ myself

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: better comment wording #39238

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

📌 Commit d896a0c has been approved by GuillaumeGomez

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 23, 2017
…umeGomez

Add more references between lowercase/uppercase operations.

None
bors added a commit that referenced this pull request Jan 23, 2017
Rollup of 7 pull requests

- Successful merges: #38794, #38956, #38993, #39191, #39200, #39233, #39258
- Failed merges:
@bors bors merged commit d896a0c into rust-lang:master Jan 24, 2017
@frewsxcv frewsxcv deleted the upper-lower-docs branch January 24, 2017 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants