Rollup of 9 pull requests #38826
Closed
Rollup of 9 pull requests #38826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are some bare-bones documentation for custom derive, needed to stabilize "macros 1.1", rust-lang#35900 The book chapter is based off of a blog post by @cbreeden, https://cbreeden.github.io/Macros11/ Normally, we have a policy of not mentioning external crates in documentation. However, given that syn/quote are basically neccesary for properly using macros 1.1, I feel that not including them here would make the documentation very bad. So the rules should be bent in this instance.
Clarify zero-value behavior of `ctlz`/`cttz` intrinsics. Fixes rust-lang#34381.
…aumeGomez Clarify behavior of `VecDeque::insert`. Fixes rust-lang#37046.
…nkov Add test for correct span for type Adds test for and closes rust-lang#27522.
…nkov Test for appropriate span on second custom derive Adds test for and closes rust-lang#36935.
Fix doc for `escape_debug`
Replace uses of `#[unsafe_destructor_blind_to_params]` with `#[may_dangle]` CC rust-lang#34761 r? @pnkfelix
…ikomatsakis Document custom derive. These are some bare-bones documentation for custom derive, needed to stabilize "macros 1.1", rust-lang#35900 The book chapter is based off of a blog post by @cbreeden, https://cbreeden.github.io/Macros11/ Normally, we have a policy of not mentioning external crates in documentation. However, given that syn/quote are basically neccesary for properly using macros 1.1, I feel that not including them here would make the documentation very bad. So the rules should be bent in this instance. So far, this PR includes only docs; @alexcrichton said in rust-lang#35900 that he'd be okay with landing them before stabilization; I don't mind either way.
…meGomez Add more docs for CoerceUnsized and Unsize here be dragons r? @ubsan @steveklabnik
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 05913bd has been approved by |
|
⌛ Testing commit 05913bd with merge bc7139b... |
|
💔 Test failed - status-travis |
|
☔ The latest upstream changes (presumably #38783) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctlz/cttzintrinsics. #38310, Clarify behavior ofVecDeque::insert. #38581, Add test for correct span for type #38606, Test for appropriate span on second custom derive #38607, Fix doc forescape_debug#38629, Replace uses of#[unsafe_destructor_blind_to_params]with#[may_dangle]#38664, Document custom derive. #38770, Doc fix #38799, Add more docs for CoerceUnsized and Unsize #38816