Rollup of 5 pull requests #37494
Merged
Rollup of 5 pull requests #37494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Oct 31, 2016
GuillaumeGomez
commented
- Successful merges: improve docs for Index and IndexMut #37438, Fix more spans in deriving::generic #37458, Remove outdated fixme comment. #37462, Add E0532 error explanation #37475, Fix typo in the BitAndAssign operator documentation #37486
- Failed merges:
improve docs for Index and IndexMut This mainly changes the boring example of Foo/Bar of `IndexMut` into a better one. Also added explanations about syntactic sugar for `v[index]`. Closes rust-lang#36329
Fix more spans in deriving::generic r? @petrochenkov
…me, r=petrochenkov Remove outdated fixme comment. Linked issue has been closed, but the comment was not removed. If this is still an issue, then the comment should probably be updated. r? @petrochenkov
…0532, r=GuillaumeGomez Add E0532 error explanation This resolves one of the error list in rust-lang#35347 - just because I stumbled over it today. I assumed the error code should be removed from `register_diagnostics!` because it's now defined above. Since that is my first code contribution, please check that all is in order. It would be helpful to know how to run the test for the `compile_fail,E0532` part. I did `make check-stage1-cfail NO_REBUILD=1` but that doesn't test the inlined example. r? @GuillaumeGomez
…pasel422 Fix typo in the BitAndAssign operator documentation The name of the operator should be `&=` instead of `&`.
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 0a59eba has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.