Rollup of 7 pull requests #37419
Merged
Rollup of 7 pull requests #37419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ p=1 |
|
📌 Commit d600c31 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit d600c31 with merge 215dd27... |
|
💔 Test failed - auto-mac-cross-ios-opt |
save_analysis: Dump data only if get_path_data doesn't fail to resolve a path. Solves rust-lang#37126 Dump data only if `get_path_data` doesn't fail to resolve a path. `get_path_data` returns `None` when it have to deals with `Def::Err`, which is used as placeholder for a failed resolution. Tell me if this is good enough, maybe I have to add some tests ? r? @nrc
GuillaumeGomez
force-pushed
the
rollup
branch
from
d600c31 to
a5b6a9f
Compare
Broken links in Vec docs Fixed some issues with quote/bracket nesting and made quoting more consistent. r? @steveklabnik
…h-id, r=GuillaumeGomez Add identifier to unused import warnings Fix rust-lang#37376. For some reason, though, I'm getting warnings with messages like "76:9: 76:16: unused import: `self::g`" instead of "unused import: `self::g`". @pnkfelix Any ideas what might be causing this?
Make error E0221 more helpful fix rust-lang#35970 as part of rust-lang#35233 r? @jonathandturner
Fix typo in libsyntax, it was bothering me May I present - the world's shortest diff.
|
@bors: r+ p=1 |
|
📌 Commit 48b0228 has been approved by |
|
⌛ Testing commit 48b0228 with merge c59cb71... |
bors
added a commit
that referenced
this pull request
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::<in types #36206, save_analysis: Dump data only if get_path_data doesn't fail to resolve a path. #37144, Broken links in Vec docs #37391, Add identifier to unused import warnings #37394, Make error E0221 more helpful #37396, Fix typo #37398, Fix typo in libsyntax, it was bothering me #37414