Skip to content

force i1 booleans to i8 when comparing #36958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2016
Merged

force i1 booleans to i8 when comparing #36958

merged 1 commit into from
Oct 5, 2016

Conversation

nikomatsakis
Copy link
Contributor

Work around LLVM bug.

cc #36856

r? @eddyb

@nikomatsakis nikomatsakis mentioned this pull request Oct 4, 2016
Closed
@eddyb
Copy link
Member

eddyb commented Oct 4, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2016

📌 Commit 3e1bd19 has been approved by eddyb

@alexcrichton
Copy link
Member

@bors: p=1

(fixing a regression)

@bors
Copy link
Collaborator

bors commented Oct 5, 2016

⌛ Testing commit 3e1bd19 with merge 506f807...

bors added a commit that referenced this pull request Oct 5, 2016
@bors
Auto merge of #36958 - nikomatsakis:issue-36856, r=eddyb
506f807 
force `i1` booleans to `i8` when comparing

Work around LLVM bug.

cc #36856

r? @eddyb
@bors
Copy link
Collaborator

bors commented Oct 5, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 506f807 to master...

@bors bors merged commit 3e1bd19 into rust-lang:master Oct 5, 2016
@bors bors mentioned this pull request Oct 5, 2016
Merged
@brson brson added beta-nominated Nominated for backporting to the compiler in the beta channel. I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2016
@brson
Copy link
Contributor

brson commented Oct 5, 2016

Nominated for backport. Regression fix (though it's been on stable a long time).

@nikomatsakis
Copy link
Contributor Author

Backport seems fine to me. This is a really simple patch.

@nikomatsakis
Copy link
Contributor Author

Accepting for beta because small patch, regression.

cc @rust-lang/compiler

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 11, 2016
@alexcrichton alexcrichton mentioned this pull request Oct 11, 2016
Merged
@brson brson removed beta-nominated Nominated for backporting to the compiler in the beta channel. I-nominated labels Oct 11, 2016
@brson brson mentioned this pull request Oct 14, 2016
Merged
@stouset
Copy link

stouset commented Oct 20, 2016

Out of curiosity, is there a plan to revert this workaround once the upstream bug is fixed?

@nikomatsakis
Copy link
Contributor Author

@stouset good question. I have no such plan. It probably makes sense to do, but I don't know an easy way to make sure we don't forget. =) I guess filing a P-medium issue might help or something.

@bstrie bstrie mentioned this pull request Apr 1, 2017
Closed
@nikomatsakis nikomatsakis deleted the issue-36856 branch April 14, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikomatsakis @eddyb @bors @alexcrichton @brson @stouset