Thread tighter span for closures around #33125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Apr 21, 2016
|
r=me (not my commit) Waiting on the other two PRs on #31645 (comment) to be approved too |
|
☔ The latest upstream changes (presumably #33089) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
force-pushed
the
closure-span
branch
from
8741fde to
99214af
Compare
|
@Manishearth travis is pointing out that there are some missing changes; either because I failed to isolate them properly, or for merge conflict reasons, not sure. |
|
@nikomatsakis Could you make a new PR with the complete changes, then? Thanks. |
Track the span corresponding to the `|...|` part of the closure.
Manishearth
force-pushed
the
closure-span
branch
from
99214af to
ecd10f0
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 24, 2016
…arth Track the span corresponding to the `|...|` part of the closure. lifted from rust-lang#32756 cc rust-lang#31645 libsyntax-[breaking change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the span corresponding to the
|...|part of the closure.lifted from #32756
cc #31645
libsyntax-[breaking change]