resolve: miscellaneous clean-ups #33060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit is also groundwork for a prototype of RFC 1560 that I'm planning. |
|
LGTM, but I'd like @nrc to also look it at. |
These tasks used to depend on the iteration order of `module_children`.
jseyfried
force-pushed
the
cleanup_resolve
branch
from
7cad0f3 to
b01e630
Compare
|
@bors: r+ |
|
📌 Commit 1e134a4 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 19, 2016
resolve: miscellaneous clean-ups This PR consists of some small, miscellaneous clean-ups in `resolve`. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of some small, miscellaneous clean-ups in
resolve.r? @eddyb