Skip to content

Conversation

angelsl
Copy link
Contributor

@angelsl angelsl commented Nov 6, 2015

@angelsl
Copy link
Contributor Author

angelsl commented Nov 6, 2015

Don't merge yet; waiting for @vadimcn and/or @vhbit to say OK

@alexcrichton
Copy link
Member

cc #29478, some more discussion there

@vadimcn, could you elaborate a bit on why you'd like a rebase? I'm curious what fun new stuff we'll be picking up!

@vadimcn
Copy link
Contributor

vadimcn commented Nov 6, 2015

@alexcrichton: I've added missing stack probe routines in the upstream repo last week. With those we should be able to replace libgcc with libcompiler-rt, at least on Windows.

@angelsl: lgtm

@alexcrichton
Copy link
Member

Fancy!

@vhbit, does this look ok to you?

@vhbit
Copy link
Contributor

vhbit commented Nov 6, 2015

@alexcrichton yep, looks good.

@alexcrichton
Copy link
Member

@bors: r+ 43e1f9a

Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 7, 2015
bors added a commit that referenced this pull request Nov 7, 2015
@bors bors merged commit 43e1f9a into rust-lang:master Nov 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants