book: miscellaneous improvements to "dining philosophers" example #29651
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| println!("{} is done eating.", self.name); | ||
| } | ||
| println!("{} is done eating.", self.name); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
This was on purpose, keeping the same indentation as the original example
There was a problem hiding this comment.
I see indentation of some previous example on this wasn't kept. Should I preserve it as well?
There was a problem hiding this comment.
Looking again, it's all inconsistent. What's the win with keeping indentation? What should the convention be?
|
I like the last half but not the first half! |
|
☔ The latest upstream changes (presumably #29666) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #29932) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: r+ |
|
📌 Commit 05dde0d has been approved by |
No description provided.