Rollup of 6 pull requests #28875
Closed
Rollup of 6 pull requests #28875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Oct 7, 2015
Manishearth
commented
- Successful merges: Fix LLVM assertion on out-of-bounds const slice index. #28841, Add error explanation for E0496 #28865, Add link to the german trpl translation #28867, doc: Mention split_whitespace in split doc #28868, book: Add documentation on custom allocators #28869, Fix reborrows of &mut pointers #28873
- Failed merges: New error code #28874
This turned up as part of rust-lang#3170. When constructing an `undef` value to return in the error case, we were trying to get the element type of the Rust-level value being indexed instead of the underlying array; when indexing a slice, that's not an array and the LLVM assertion failure reflects this. The regression test is a lightly altered copy of `const-array-oob.rs`.
This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
This turned up as part of rust-lang#3170. When constructing an `undef` value to return in the error case, we were trying to get the element type of the Rust-level value being indexed instead of the underlying array; when indexing a slice, that's not an array and the LLVM assertion failure reflects this. The regression test is a lightly altered copy of `const-array-oob.rs`.
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 force |
|
📌 Commit 480166b has been approved by |
|
⌛ Testing commit 480166b with merge fc218b7... |
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors r+ force |
|
📌 Commit ec7966a has been approved by |
|
@bors force |
|
⌛ Testing commit ec7966a with merge 890b516... |
|
💔 Test failed - auto-win-gnu-64-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.