Skip to content

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 15, 2015

I'd love to have any tips about highlights and lang stuff I missed. Sadly, this needs to be merged tomorrow.

Rendered

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 15, 2015
is overridden and optimized by the implementations for scalars.
* The [`Hasher`] trait now has a number of specialized `write_*`
methods for primitive types, for efficiency.
* The I/O-specific error type, [`std::io::Error`][ie], gained a set of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io::Error::cause also now forwards to the inner Error's.

@arielb1
Copy link
Contributor

arielb1 commented Sep 15, 2015

unused_mut, unconditional_recursion, improper_ctypes, and negate_unsigned became more strict.

@arielb1
Copy link
Contributor

arielb1 commented Sep 15, 2015

@arielb1
Copy link
Contributor

arielb1 commented Sep 15, 2015

@arielb1
Copy link
Contributor

arielb1 commented Sep 15, 2015

@brson
Copy link
Contributor Author

brson commented Sep 15, 2015

Woohoo! Thanks for the review folks. This helps a lot.

@bluss
Copy link
Contributor

bluss commented Sep 15, 2015

I think #26241 is in 1.3 as well? It allows a slew of mutable functionality to String and &mut str. In the end, the library functionality it enables is rather limited, but you can now produce &mut str easily through slicing.

@brson
Copy link
Contributor Author

brson commented Sep 15, 2015

@bluss I you are right. I didn't include it because I thought it wasn't stable, but it's 'insta-stable'.

@brson
Copy link
Contributor Author

brson commented Sep 15, 2015

@brson
Copy link
Contributor Author

brson commented Sep 15, 2015

r? @aturon

Last call. I will back port these in an hour.

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Sep 15, 2015
@aturon
Copy link
Contributor

aturon commented Sep 15, 2015

@brson: LGTM

@brson
Copy link
Contributor Author

brson commented Sep 15, 2015

@bors r=aturon

@bors
Copy link
Collaborator

bors commented Sep 15, 2015

📌 Commit f57bb9d has been approved by aturon

@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 15, 2015
@brson brson mentioned this pull request Sep 15, 2015
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 15, 2015
@bors
Copy link
Collaborator

bors commented Sep 15, 2015

⌛ Testing commit f57bb9d with merge 5e44115...

bors added a commit that referenced this pull request Sep 15, 2015
I'd love to have any tips about highlights and lang stuff I missed. Sadly, this needs to be merged *tomorrow*.

[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md)
@bors bors merged commit f57bb9d into rust-lang:master Sep 15, 2015
[win2]: https://github.com/rust-lang/rust/pull/26741
[win3]: https://github.com/rust-lang/rust/pull/26741
[win4]: https://github.com/rust-lang/rust/pull/27210
[xp]: https://github.com/rust-lang/rust/pull/26569
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be #26601 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.