TRPL: Borrow and AsRef #24996
Merged
TRPL: Borrow and AsRef #24996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Maybe you could include the output here.
|
Sorry for the long delay... This looks good! Other than making sure to emphasize that these are specifically for use with generics, you should also mention that |
These two traits are commonly confused. As such, explain the difference. Fixes rust-lang#24163
|
@bors: r=aturon rollup |
|
📌 Commit e780fb2 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 12, 2015
These two traits are commonly confused. As such, explain the difference. Fixes rust-lang#24163 r? @aturon
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 12, 2015
These two traits are commonly confused. As such, explain the difference. Fixes rust-lang#24163 r? @aturon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two traits are commonly confused. As such, explain the difference.
Fixes #24163
r? @aturon