Skip to content

Conversation

GuillaumeGomez and others added 9 commits April 19, 2015 00:01
this is too small for its own thing, I think.
`ToCStr` was removed with `old_io` and the current method `as_os_str`
is inherent to `Path`, meaning there is no suitable trait bound that
could be used here.
`us` and `is` were replaced with `usize` and `isize` some time ago.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors: r+ force p=10

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit f772079 has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: force

bors added a commit that referenced this pull request Apr 24, 2015
@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit f772079 with merge 2efcd0b...

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

💔 Test failed - auto-mac-32-opt

@Manishearth
Copy link
Member Author

@bors: r+ p=10

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit 874e093 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit 874e093 with merge f90f9e8...

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: r+ p=10

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit 874e093 has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: force

1 similar comment
@Manishearth
Copy link
Member Author

@bors: force

@Manishearth
Copy link
Member Author

@bors: r+ p=10

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit 874e093 has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors: retry

ah

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit 874e093 with merge 71c92fa...

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

💔 Test failed - auto-linux-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: r+ force

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit ae3c27c has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit ae3c27c with merge 1f52dee...

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

💔 Test failed - auto-mac-64-opt

@Manishearth
Copy link
Member Author

@bors: r+ force

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit 1447ee4 has been approved by Manishearth

bors added a commit that referenced this pull request Apr 24, 2015
@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit 1447ee4 with merge f191f92...

…r=steveklabnik

this is too small for its own thing, I think.
…ichton

`ToCStr` was removed with `old_io` and the current method `as_os_str`
is inherent to `Path`, meaning there is no suitable trait bound that
could be used here.

r? @alexcrichton
…crichton

r? @alexcrichton (since you added `.stability` warning messages)
`us` and `is` were replaced with `usize` and `isize` some time ago. Other than that, 3.5.2.1.5 is correct.
…bnik

It was in pretty good shape, but since that is my pet peeve, I clarified the compiler/interpreter distinction and why it is irrelevant for this section. Otherwise only a couple of minor clarifications, and weasel words where reality is more complicated than the text accounted for (e.g., there is more than one kind of library).

r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Apr 24, 2015

@bors bors merged commit 1447ee4 into rust-lang:master Apr 24, 2015
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.