Rollup of 15 pull requests

[steveklabnik]

• Successful merges: Omit 'obsolete' note for a warning with -Awarning #23782, Add long diagnostics for E0152, E0158, E0161, E0170, E0306, E0307 #24455, Fix some documentation typos #24490, Fix link id for stackoverflow #24493, Use BTreeMap in build_sidebar_items #24494, Fixed double sentence in hash_map::Entry documentation #24496, Fix some broken links in the book #24498, Add Debug to MethodCallee #24499, Indicate None is code-like in doc comments #24501, document missing attributes in the reference #24502, Make note of possible XSS in Rustdoc #24506, remove example usage of from_str in error docs #24507, Make note of documentation tests and binaries #24508, Descripe tuple indexing in TRPL #24509, Fix broken links in the docs #24510
• Failed merges: Add long diagnostics for E0015 and E0020. #24488

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[steveklabnik]

@bors: r+ p=1337

[bors]

📌 Commit ed09a7c has been approved by steveklabnik

[bors]

⌛ Testing commit ed09a7c with merge fb4ab3b...

[bors]

💔 Test failed - auto-mac-32-opt

[steveklabnik]

Rebased the fix into my commit

[steveklabnik]

@bors: r+ p=1000

[bors]

📌 Commit 2aab9a6 has been approved by steveklabnik

[bors]

⌛ Testing commit 2aab9a6 with merge 88773f4...

[bors]

💔 Test failed - auto-mac-32-opt

[bors]

📌 Commit a4be1ec has been approved by steveklabnik

[steveklabnik]

man, i screwed up today :(

[bors]

⌛ Testing commit a4be1ec with merge b7fb575...

[bors]

💔 Test failed - auto-linux-32-nopt-t

[Manishearth]

---- [compile-fail] compile-fail/asm-src-loc-codegen-units.rs stdout ----

error: error pattern ' build without -C codegen-units for more exact errors' not found!
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/test/compile-fail/asm-src-loc-codegen-units.rs -L i686-unknown-linux-gnu/test/compile-fail/ --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-i686-unknown-linux-gnulibaux -C prefer-dynamic -o i686-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-i686-unknown-linux-gnu --cfg rtopt --cfg ndebug -L i686-unknown-linux-gnu/rt -C codegen-units=2
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread 'error: <inline asm>:1:2: error: invalid instruction mnemonic 'nowayisthisavalidinstruction'
        nowayisthisavalidinstruction
        ^
codegen-1
' panicked at 'Box<Any>note: ', /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/libsyntax/diagnostic.rsbuild without -C codegen-units for more exact errors:
171
error: aborting due to previous error
error: aborting due to worker thread panic

------------------------------------------

thread '[compile-fail] compile-fail/asm-src-loc-codegen-units.rs' panicked at 'explicit panic', /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/compiletest/runtest.rs:1499

[Manishearth]

@bors: retry force

Wait, looks like the note got hit by a race.

[bors]

⚡ Previous build results for auto-linux-64-nopt-t, auto-mac-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

[Manishearth]

Note: I'm working on the next rollup (https://github.com/Manishearth/rust/compare/rollup), but I haven't finished testing it yet so I'll wait for this to go through.

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt