Feature gate rust-call ABI. #23948
Merged
Feature gate rust-call ABI. #23948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
feature-gate-rust-abi
branch
from
5cfef21 to
d81e866
Compare
| self.gate_feature("intrinsics", | ||
| span, | ||
| "intrinsics are subject to change") | ||
| } | ||
| visit::FkItemFn(_, _, _, abi) | | ||
| visit::FkMethod(_, &ast::MethodSig { abi, .. }) if abi == Abi::RustCall => { | ||
| self.gate_feature("unboxed_closures", |
There was a problem hiding this comment.
should this say something other than unboxed_closures?
There was a problem hiding this comment.
from the tests, it looks like @nikomatsakis deliberately chose to (re?)use that feature name rather than add a new one ... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like it says.
r? @alexcrichton