Make Index trait example clearer #21255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example of the `Index` and `IndexMut` trait contained too much `Foo`. It now contains a bit more `Bar` to make things clearer which parts are defining the type of the index.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! |
bors
referenced
this pull request
Jan 16, 2015
bors
added a commit
that referenced
this pull request
Jan 17, 2015
Make Index trait example clearer Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 17, 2015
bors
added a commit
that referenced
this pull request
Jan 17, 2015
Make Index trait example clearer Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 17, 2015
|
Doing this manually as part of #21300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example of the
IndexandIndexMuttrait contained too muchFoo.It now contains a bit more
Barto make things clearer which parts aredefining the type of the index.