Return the String guide to its former glory. #21056
Conversation
| let string = "Hello there."; | ||
| ``` | ||
|
|
||
| Like any Rust type, string slices have an associated lifetime. A string literal |
There was a problem hiding this comment.
"Like any Rust reference type" maybe?
|
r? @sfackler |
steveklabnik
force-pushed
the
return_strings
branch
from
5d74940 to
e68865b
Compare
|
This has been updated now. |
|
|
||
| Like vector slices, string slices are simply a pointer plus a length. This | ||
| means that they're a 'view' into an already-allocated string, such as a | ||
| `&'static str` or a `String`. |
There was a problem hiding this comment.
Using &'static str here seems wrong, maybe "string literal"?
There was a problem hiding this comment.
Why is it wrong?
There was a problem hiding this comment.
It just seems a bit strange since the paragraph's saying that slices are a view into an already allocated string, such as a slice, but isn't that a view into an already allocated string?
There was a problem hiding this comment.
I guess it is strange because it's an edge case: a &'static str is an always-allocated thing. And I tend to refer to things by their type explicitly. But I can see that. Lemme fix it.
|
r=me with the one last nit. |
steveklabnik
force-pushed
the
return_strings
branch
from
e68865b to
b33dfdb
Compare
|
@bors: r=sfackler b33dfdb rollup |
|
⌛ Testing commit b33dfdb with merge 1fcaec0... |
|
💔 Test failed - auto-mac-64-opt |
steveklabnik
force-pushed
the
return_strings
branch
from
b33dfdb to
cef8295
Compare
When we moved over to the book, we lost this.
|
Woo |
…kler When we moved over to the book, we lost this.
When we moved over to the book, we lost this.