Add ExactSizeIterator impls for Hash{Map, Set, Table} #20915
Conversation
This commit also changes the return types of all `size_hint()` impls in these files from (uint, Option<uint>) to (usize, Option<usize>).
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @gankro |
There was a problem hiding this comment.
I'm not sure this is strictly necessary, but sure.
There was a problem hiding this comment.
I figured I'd avoid the unnecessary size_hint() unwrap by just calling straight down, but these can be removed if desired.
There was a problem hiding this comment.
This is the strictly more correct thing, although if T: ExactSize, then size_hint is probably trivially inlineable to discard the upper-bound creation. This is fine as is; we need a better story for impl forwarding anyway (but thanks for soldiering through all this in the interim!)
There was a problem hiding this comment.
No problem! And I'll be happy to bring this in line with impl forwarding conventions if and when we get them if this happens to run afoul of them.
Add ExactSizeIterator impls for Hash{Map, Set, Table}
Reviewed-by: Gankro
…-let Fix not applicable on while for replace_is_method_with_if_let_method
…-let Fix not applicable on while for replace_is_method_with_if_let_method
5 participants
Since
ExactSizeIteratorwas decoupled fromDoubleEndedIterator, it's now more or less "free" to implement ExactSizeIterator for these iterators. Not sure if this is even something that we want, but it was quick and easy enough to do that I thought I'd open a PR for it and see.This commit also changes the return types of all
size_hint()impls in these files from(uint, Option<uint>)to(usize, Option<usize>)since I was already in there and it's a closely related change.