Several fixes for DragonFly #19852
Closed
Several fixes for DragonFly #19852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using /proc/curproc/file does not resolve mount-points as sysctl(3) with KERN_PROC_PATHNAME does, which gave back paths containing colons like /pfs/@@-1:00004/usr/bin. This led to problems when joining paths based on it.
bors
added a commit
that referenced
this pull request
Dec 16, 2014
Several fixes for DragonFly Reviewed-by: brson
bors
referenced
this pull request
Dec 16, 2014
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
bors
added a commit
that referenced
this pull request
Dec 16, 2014
Several fixes for DragonFly Reviewed-by: brson
This reverts commit 6f4a406. Paths only moved from /usr/local/lib to /usr/lib.
|
Could you squash these commits together as well? (looks like you can just strip the last two) |
|
@alexcrichton: Opened up #20015 where I squashed them. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.