properly annotate C code in the guide #17239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without 'notrust,' we were getting a playpen link. Fixes rust-lang#17228.
|
Hm, shouldn't we use the logic as implemented in rustdoc? If it's not marked as rust or nothing at all, it should be ignored? |
|
Theoretically that logic is there, I think writing this as (i.e. remove the |
|
I've made this change in the rollup PR, thanks. |
Merged
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
May 19, 2024
internal: Key ignoring the job-id in metrics cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without 'notrust,' we were getting a playpen link.
Fixes #17228.