change String::from_str() to .to_string() #15519
Conversation
|
Travis seemed to timed out hence the error. Not sure how to trigger a new run. |
|
Seems like a poor time to do this migration, when |
|
As of #15493 it's not obvious that |
|
This may mostly touch test cases, but it sets a precedent and suggests more PRs should be submitted that do the same transformation elsewhere. My recommendation is to avoid doing any of this work until we have a better idea about how to make |
|
Ah, well, never mind then. I was referring to iron/iron#86 (comment) and thought it might be a patch small enough to get me started with some non-documentation patches. I'll find something different to hack on ;-) |
|
@cburgdorf That's a reasonable reaction to that comment, TBH. It just happens to come at an inopportune time. For new code, certainly, use Thank you for your contribution, and I'm looking forward to whatever else you submit. I'm closing this PR at this time for the already-discussed reasons. Once |
|
👍 |
For rust-lang/rust-clippy#7784 The first commit is for all the places with rather trivial changes: - replacing nested `is_diagnostic_item` `if`s with a match on `get_diagnostic_item` - storing the result of `get_diagnostic_item` in a variable and reusing it The rest of commits are for more involved changes, and for places where changing to `get_diagnostic_item` allowed further simplifications -- in the latter case, the follow-up commits are marked as `misc: ` This is roughly one evening's worth of changes, so I hope the amount won't be overwhelming^^ changelog: none
I recently learned from @huonw that
"foo".to_string()should be preferred overString::from_str("foo").This commit updates
tutorial.md,rc.rsandstring.rsaccording to the convention.There are more files to be patched but I thought it might be fine to patch them in batches.