-
Notifications
You must be signed in to change notification settings - Fork 14k
perf: removed unnecessary let for return only in layout.rs #148093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
perf: removed unnecessary let for return only
|
This won't have any performance impact. At best it could make the code nicer to look at. |
| let align_m1 = unchecked_sub(align.as_usize(), 1); | ||
| let size_rounded_up = unchecked_add(self.size, align_m1) & !align_m1; | ||
| size_rounded_up | ||
| unchecked_add(self.size, align_m1) & !align_m1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commentary above already contains the same information as the let-for-comment-binding, so I suppose getting rid of it is fine.
|
@bors r+ rollup |
|
How about rewording the title and description? |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 292db4a (parent) -> 292be5c (this PR) Test differencesShow 11 test diffs11 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 292be5c7c05138d753bbd4b30db7a3f1a5c914f7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (292be5c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.353s -> 475.908s (-0.09%) |
perf: removed unnecessary let for return only