-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Rework unsizing coercions in the new solver #147840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor changes to |
This comment has been minimized.
This comment has been minimized.
can you split the old solver custom fulfillment loop out into its own function? named something that makes it clear that its old solver specific too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add comments to the added tests explaining why we've added them and also link to the relevant issues
fn foo<'a>(x: Box<dyn Trait<'a>>) -> Box<dyn Super<'a>> { | ||
x | ||
//~^ ERROR type annotations needed: cannot satisfy `dyn Trait<'_>: Unsize<dyn Super<'_>> | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this one not use revisions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question 🤔 it should get some :)
9846ace
to
316479a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
316479a
to
4b66d2b
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
4b66d2b
to
29f04e0
Compare
This comment has been minimized.
This comment has been minimized.
29f04e0
to
f2d7236
Compare
Replaces #141926, contains:
I hope this is roughly what you had in mind
r? @lcnr