-
Notifications
You must be signed in to change notification settings - Fork 14k
[Debugger Visualizers] Unify *-gnu and *-msvc enum output
#147760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
1d2d783 to
fe612ac
Compare
This comment has been minimized.
This comment has been minimized.
fe612ac to
d8b5ad9
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
|
@bors rollup=iffy |
|
☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts. |
d8b5ad9 to
91fed12
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
91fed12 to
b32411e
Compare
|
@rustbot review |
|
@bors r+ |
…ulacrum [Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output Followup patch to rust-lang#145218 Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused rust-lang#147450 <img width="629" height="220" alt="image" src="https://github.com/user-attachments/assets/d6ae44d5-232f-412d-b291-64ac52850c74" /> I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.
|
@bors r=Mark-Simulacrum,saethlin |
|
This PR still needs the merge conflicts fixed, but I've delta reviewed the fix for the merge failure and now I'm subscribed :) |
8f2de75 to
11a30ba
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=Mark-Simulacrum,saethlin |
…thlin [Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output Followup patch to #145218 Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused #147450 <img width="629" height="220" alt="image" src="https://github.com/user-attachments/assets/d6ae44d5-232f-412d-b291-64ac52850c74" /> I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Whoops 🤦♂️ |
11a30ba to
af1c2b2
Compare
|
@bors r=Mark-Simulacrum,saethlin |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d3e1ccd (parent) -> 69408a8 (this PR) Test differencesShow 3 test diffs3 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 69408a877e11c759a9d94f152b8333c929133d9b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (69408a8): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 6.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.149s -> 469.334s (-0.60%) |
Followup patch to #145218
Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused #147450
I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.