Skip to content

Conversation

@Walnut356
Copy link
Contributor

@Walnut356 Walnut356 commented Oct 16, 2025

Followup patch to #145218

Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused #147450

image

I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

📌 Commit d8b5ad9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2025
@matthiaskrgr
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2025
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Walnut356
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2025

📌 Commit b32411e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 17, 2025
…ulacrum

[Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output

Followup patch to rust-lang#145218

Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused rust-lang#147450

<img width="629" height="220" alt="image" src="https://github.com/user-attachments/assets/d6ae44d5-232f-412d-b291-64ac52850c74" />

I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.
@saethlin
Copy link
Member

@bors r=Mark-Simulacrum,saethlin

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

📌 Commit 8f2de75 has been approved by Mark-Simulacrum,saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2025
@saethlin
Copy link
Member

This PR still needs the merge conflicts fixed, but I've delta reviewed the fix for the merge failure and now I'm subscribed :)

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@saethlin
Copy link
Member

@bors r=Mark-Simulacrum,saethlin

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

📌 Commit 11a30ba has been approved by Mark-Simulacrum,saethlin

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

⌛ Testing commit 11a30ba with merge a62b132...

bors added a commit that referenced this pull request Nov 24, 2025
…thlin

[Debugger Visualizers] Unify `*-gnu` and `*-msvc` enum output

Followup patch to #145218

Ports the msvc enum synthetic/summary logic to the gnu handlers so they have identical output. Also removes the "look-through-pointers" logic that caused #147450

<img width="629" height="220" alt="image" src="https://github.com/user-attachments/assets/d6ae44d5-232f-412d-b291-64ac52850c74" />

I know we don't run the test suite in CI anymore, but it's still useful locally so I updated the relevant tests.
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2025
@Walnut356
Copy link
Contributor Author

Whoops 🤦‍♂️

@saethlin
Copy link
Member

@bors r=Mark-Simulacrum,saethlin

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

📌 Commit af1c2b2 has been approved by Mark-Simulacrum,saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2025
@bors
Copy link
Collaborator

bors commented Nov 24, 2025

⌛ Testing commit af1c2b2 with merge 69408a8...

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum,saethlin
Pushing 69408a8 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2025
@bors bors merged commit 69408a8 into rust-lang:main Nov 24, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 24, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d3e1ccd (parent) -> 69408a8 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 69408a877e11c759a9d94f152b8333c929133d9b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 4006.3s -> 3201.3s (-20.1%)
  2. dist-x86_64-solaris: 4922.1s -> 5549.1s (+12.7%)
  3. x86_64-gnu-aux: 6521.9s -> 5753.7s (-11.8%)
  4. pr-check-1: 1902.4s -> 1684.5s (-11.5%)
  5. aarch64-msvc-2: 5275.1s -> 4719.7s (-10.5%)
  6. aarch64-apple: 8990.9s -> 9848.7s (+9.5%)
  7. x86_64-msvc-1: 9215.2s -> 8481.1s (-8.0%)
  8. dist-x86_64-apple: 7061.2s -> 7613.1s (+7.8%)
  9. x86_64-msvc-2: 7148.1s -> 6607.8s (-7.6%)
  10. x86_64-gnu-llvm-20-3: 6201.6s -> 5735.1s (-7.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (69408a8): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.0% [-1.0%, -1.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 6.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.1% [6.1%, 6.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.149s -> 469.334s (-0.60%)
Artifact size: 388.26 MiB -> 388.26 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants