Further tighten up relaxed bounds #147734

fmease · 2025-10-15T18:00:03Z

Follow-up to #142693, #135331 and #135841.
Fixes #143122.

Reject relaxed bounds ?Trait in the bounds of trait aliases.
Just like trait Trait {} doesn't mean trait Trait: Sized {} and we therefore reject trait Trait: ?Sized {}, trait Trait =; (sic!) doesn't mean trait Trait = Sized; (never did!) and as a logical consequence trait Trait = ?Sized; is meaningless and should be forbidden.
Don't permit ?Sized in more places (e.g., supertrait bounds, trait object types) if feature more_maybe_bounds is enabled.
That internal feature is only meant to allow the user to define & use new default traits (that have fewer rules to follow for now to ease experimentation).
Unconditionally check that the Trait in ?Trait is a default trait.
Previously, we would only perform this check in selected places which was very brittle and led to bugs slipping through.
Slightly improve diagnostics.

fmease · 2025-10-15T18:00:18Z

Further tighten up relaxed bounds

rust-bors · 2025-10-15T20:10:53Z

☀️ Try build successful (CI)
Build commit: 9ed9a73 (9ed9a7337cbbb431708bcd7085fadfe1719c28c3, parent: 28d0a4a205f9e511ad2f51ee79a4aa19a704a455)

rust-timer · 2025-10-15T23:51:40Z

Finished benchmarking commit (9ed9a73): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.8%	[-6.7%, -1.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.8%	[-6.7%, -1.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.854s -> 475.36s (0.11%)
Artifact size: 388.09 MiB -> 388.06 MiB (-0.01%)

fmease · 2025-10-16T15:38:22Z

@bors rollup-

… was enabled The internal feature `more_maybe_bounds` doesn't influence sized elaboration in HIR ty lowering and therefore doesn't get to dictate where `?Sized` is allowed.

fmease · 2025-10-16T17:24:31Z

tests/ui/sized-hierarchy/trait-aliases.rs

"Completely" unrelated to feature sized_hierarchy. Well, it must've once ICE'd during the development of sized_hierarchy and the PR that introduced it did affect stable behavior.

In any case, since ?Sized is now illegal inside trait alias bounds, this is now covered by test tests/ui/traits/alias/relaxed-bounds.rs.

fmease · 2025-10-16T17:26:28Z

tests/ui/traits/alias/empty.rs

Indeed, we did not have any UI test for trait Empty =; prior.

fmease · 2025-10-16T17:27:44Z

tests/ui/traits/alias/only-maybe-bound.rs

Superseded by tests/ui/traits/alias/effectively-empty-trait-object-type.rs.

fmease · 2025-10-16T17:28:27Z

tests/ui/traits/wf-object/only-maybe-bound.rs

Moved into tests/ui/unsized/relaxed-bounds-invalid-places.rs.

fmease · 2025-10-16T17:28:53Z

tests/ui/traits/alias/maybe-bound.rs

Superseded by tests/ui/traits/alias/relaxed-bounds.rs.

fmease · 2025-10-16T17:33:56Z

tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs

+//~| ERROR bound modifier `?` can only be applied to `Sized`
+//~| ERROR bound modifier `?` can only be applied to `Sized`
+//~| ERROR bound modifier `?` can only be applied to `Sized`


Duplicate diagnostics (under -Zdeduplicate-diagnostics=no) because we lower the supertraits multiple times during HIR ty lowering likely under different predicate filters (HIR ty lowering needs to do this sort of thing in a bunch of situations to avoid query cycles).

fmease · 2025-10-16T17:35:07Z

tests/ui/trait-bounds/more_maybe_bounds.rs

(This test is just a mixed bag, always has been, and that's fine, the feature is internal and still evolving)

fmease · 2025-10-16T17:35:26Z

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

-            trait_ref.path.segments.split_last().unwrap().1.iter(),
-            GenericsArgsErrExtend::None,
-        );
+        let [leading_segments @ .., segment] = trait_ref.path.segments else { bug!() };


Drive-by refactoring

fmease · 2025-10-16T17:54:36Z

r? compiler

petrochenkov · 2025-10-17T12:14:09Z

r? types

fmease · 2025-10-17T14:30:34Z

r? types

lcnr · 2025-10-20T08:30:54Z

gamer!

@bors r+ rollup

bors · 2025-10-20T08:30:56Z

📌 Commit 65814c8 has been approved by lcnr

It is now in the queue for this repository.

bors · 2025-10-20T08:32:46Z

⌛ Testing commit 65814c8 with merge 5da91e4...

Further tighten up relaxed bounds Follow-up to #142693, #135331 and #135841. Fixes #143122. * Reject relaxed bounds `?Trait` in the bounds of trait aliases. Just like `trait Trait {}` doesn't mean `trait Trait: Sized {}` and we therefore reject `trait Trait: ?Sized {}`, `trait Trait =;` (sic!) doesn't mean `trait Trait = Sized;` (never did!) and as a logical consequence `trait Trait = ?Sized;` is meaningless and should be forbidden. * Don't permit `?Sized` in more places (e.g., supertrait bounds, trait object types) if feature `more_maybe_bounds` is enabled. That internal feature is only meant to allow the user to define & use *new* default traits (that have fewer rules to follow for now to ease experimentation). * Unconditionally check that the `Trait` in `?Trait` is a default trait. Previously, we would only perform this check in selected places which was very brittle and led to bugs slipping through. * Slightly improve diagnostics.

bors · 2025-10-20T08:37:17Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-10-20T08:58:48Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#3 [auth] library/centos:pull token for registry-1.docker.io
#3 DONE 0.0s

#4 [internal] load metadata for docker.io/library/centos:7
#4 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


------
---
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


Command failed. Attempt 2/5:
---
#2 [auth] library/centos:pull token for registry-1.docker.io
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/library/centos:7
#3 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


------
---
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


Command failed. Attempt 3/5:
---
#2 [auth] library/centos:pull token for registry-1.docker.io
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/library/centos:7
#3 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


------
---
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


Command failed. Attempt 4/5:
---
#2 [auth] library/centos:pull token for registry-1.docker.io
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/library/centos:7
#3 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


------
---
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


Command failed. Attempt 5/5:
---
#2 [auth] library/centos:pull token for registry-1.docker.io
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/library/centos:7
#3 ERROR: failed to authorize: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


------
---
   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to build: failed to solve: failed to fetch oauth token: unexpected status from POST request to https://auth.docker.io/token: 503 Service Unavailable: <html><body><h1>503 Service Unavailable</h1>
No server is available to handle this request.
</body></html>


The command has failed after 5 attempts.

Zalathar · 2025-10-20T10:17:38Z

Docker appears to be working again.

@bors retry

Rollup of 4 pull requests Successful merges: - #147734 (Further tighten up relaxed bounds) - #147888 (enzyme/autodiff is compatible with download-ci=true) - #147898 (compiletest: Move `AuxProps` out of `EarlyProps`) - #147903 (compiletest: Store the selected edition in `TestProps`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147734 - fmease:tighten-relaxed, r=lcnr Further tighten up relaxed bounds Follow-up to #142693, #135331 and #135841. Fixes #143122. * Reject relaxed bounds `?Trait` in the bounds of trait aliases. Just like `trait Trait {}` doesn't mean `trait Trait: Sized {}` and we therefore reject `trait Trait: ?Sized {}`, `trait Trait =;` (sic!) doesn't mean `trait Trait = Sized;` (never did!) and as a logical consequence `trait Trait = ?Sized;` is meaningless and should be forbidden. * Don't permit `?Sized` in more places (e.g., supertrait bounds, trait object types) if feature `more_maybe_bounds` is enabled. That internal feature is only meant to allow the user to define & use *new* default traits (that have fewer rules to follow for now to ease experimentation). * Unconditionally check that the `Trait` in `?Trait` is a default trait. Previously, we would only perform this check in selected places which was very brittle and led to bugs slipping through. * Slightly improve diagnostics.

Rollup of 4 pull requests Successful merges: - rust-lang/rust#147734 (Further tighten up relaxed bounds) - rust-lang/rust#147888 (enzyme/autodiff is compatible with download-ci=true) - rust-lang/rust#147898 (compiletest: Move `AuxProps` out of `EarlyProps`) - rust-lang/rust#147903 (compiletest: Store the selected edition in `TestProps`) r? `@ghost` `@rustbot` modify labels: rollup

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Oct 15, 2025

Auto merge of #147734 - fmease:tighten-relaxed, r=<try>

9ed9a73

Further tighten up relaxed bounds

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 15, 2025

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 15, 2025

fmease force-pushed the tighten-relaxed branch 2 times, most recently from 2453034 to 5fab794 Compare October 16, 2025 14:19

fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Oct 16, 2025

fmease force-pushed the tighten-relaxed branch from 5fab794 to c67d187 Compare October 16, 2025 15:39

fmease removed the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Oct 16, 2025

fmease force-pushed the tighten-relaxed branch 2 times, most recently from 79993ba to 86cd4b0 Compare October 16, 2025 17:20

fmease added 5 commits October 16, 2025 19:53

Tweak diagnostics for relaxed bounds in invalid positions

690a8a6

Reject relaxed bounds inside trait alias bounds

ce68cd3

Don't permit ?Sized in more places just because more_maybe_bounds…

aee9d3b

… was enabled The internal feature `more_maybe_bounds` doesn't influence sized elaboration in HIR ty lowering and therefore doesn't get to dictate where `?Sized` is allowed.

More robustly reject relaxing non-default trait bounds

03dfb84

Guard us against degenerate default traits

65814c8

fmease force-pushed the tighten-relaxed branch from 86cd4b0 to 65814c8 Compare October 16, 2025 17:53

fmease commented Oct 16, 2025

View reviewed changes

fmease marked this pull request as ready for review October 16, 2025 17:54

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2025

rustbot assigned petrochenkov and unassigned SparrowLii Oct 16, 2025

rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Oct 17, 2025

rustbot assigned spastorino and unassigned petrochenkov Oct 17, 2025

rustbot assigned lcnr and unassigned spastorino Oct 17, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2025

Zalathar mentioned this pull request Oct 20, 2025

Rollup of 4 pull requests #147906

Merged

bors merged commit f87f9a4 into rust-lang:master Oct 20, 2025
11 of 12 checks passed

rustbot added this to the 1.92.0 milestone Oct 20, 2025

fmease deleted the tighten-relaxed branch October 20, 2025 16:41

Further tighten up relaxed bounds #147734

Further tighten up relaxed bounds #147734

Conversation

fmease commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Oct 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

rust-bors bot commented Oct 15, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Oct 15, 2025

Overall result: no relevant changes - no action needed

Uh oh!

fmease commented Oct 16, 2025

Uh oh!

fmease Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmease commented Oct 16, 2025

Uh oh!

petrochenkov commented Oct 17, 2025

Uh oh!

fmease commented Oct 17, 2025

Uh oh!

lcnr commented Oct 20, 2025

Uh oh!

bors commented Oct 20, 2025

Uh oh!

bors commented Oct 20, 2025

Uh oh!

bors commented Oct 20, 2025

Uh oh!

rust-log-analyzer commented Oct 20, 2025

Uh oh!

Zalathar commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

fmease commented Oct 15, 2025 •

edited

Loading

fmease Oct 16, 2025 •

edited

Loading

fmease Oct 16, 2025 •

edited

Loading