-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[beta] Revert "compiler: Add Windows resources to rustc-main and rustc_driver" #146687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 095fa86.
Some changes occurred in compiler/rustc_codegen_ssa These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Is there a reason is this a beta-only revert, instead of also reverting on master? The affected user will still have broken master builds, no? |
Or is the intention to fix-forward on master with #146663? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors r+ rollup=never |
Giving this a small p=1 bump because beta revert. |
One of the jobs flaked out and stopped making progress, hours ago. 😿 @bors retry |
☀️ Test successful - checks-actions |
This reverts #146018 due to #146693