cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 3) #146631
+149
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
Zalathar
changed the title
nnethercote
reviewed
Sep 16, 2025
|
|
||
| pub(crate) fn LLVMDIBuilderCreateSubroutineType<'ll>( | ||
| Builder: &DIBuilder<'ll>, | ||
| File: Option<&'ll Metadata>, // (unused) |
There was a problem hiding this comment.
What does (unused) mean?
There was a problem hiding this comment.
The underlying LLVM-C function ignores the File argument, discarding it with no effect.
I've rephrased this comment to // (ignored and has no effect).
There was a problem hiding this comment.
(When the C API function was originally added, it needed a file argument, but subsequent changes to the underlying C++ code mean that it no longer does anything.)
nnethercote
reviewed
Sep 16, 2025
| } | ||
| } | ||
|
|
||
| fn create_pointer_type<'ll>( |
|
This stuff is unfamiliar to me but it all looks pretty straightforward. I will delegate approval just in case there's a change to made in response to my question about "(unused)". @bors delegate=Zalathar |
|
✌️ @Zalathar, you can now approve this pull request! If @nnethercote told you to " |
Zalathar
force-pushed
the
di-builder
branch
from
145561c to
7ab4175
Compare
|
I've added some clarification to the “ignored” file parameter. @nnethercote Did you intend to |
nnethercote
approved these changes
Sep 17, 2025
| unsafe { | ||
| llvm::LLVMDIBuilderCreateSubroutineType( | ||
| DIB(cx), | ||
| None, // (unused) |
There was a problem hiding this comment.
Can you change this one to (ignored and has no effect) to match? r=me with that, thanks.
Zalathar
force-pushed
the
di-builder
branch
from
7ab4175 to
af88d14
Compare
|
@bors r=nnethercote rollup |
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 17, 2025
cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 3) - Part of rust-lang#134001 - Follow-up to rust-lang#136375 - Follow-up to rust-lang#136632 --- This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs. This PR migrates all of the bindings that were touched by rust-lang#136632, plus `LLVMDIBuilderCreateStructType`.
This was referenced Sep 17, 2025
bors
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup of 14 pull requests Successful merges: - #142807 (libtest: expose --fail-fast as an unstable command-line option) - #144871 (Stabilize `btree_entry_insert` feature) - #145071 (Update the minimum external LLVM to 20) - #145181 (remove FIXME block from `has_significant_drop`, it never encounters inference variables) - #145660 (initial implementation of the darwin_objc unstable feature) - #145838 (don't apply temporary lifetime extension rules to non-extended `super let`) - #146259 (Suggest removing Box::new instead of unboxing it) - #146410 (Iterator repeat: no infinite loop for `last` and `count`) - #146460 (Add tidy readme) - #146552 (StateTransform: Do not renumber resume local.) - #146564 (Remove Rvalue::Len again.) - #146581 (Detect attempt to use var-args in closure) - #146588 (tests/run-make: Update list of statically linked musl targets) - #146631 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 3)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup merge of #146631 - Zalathar:di-builder, r=nnethercote cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 3) - Part of #134001 - Follow-up to #136375 - Follow-up to #136632 --- This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs. This PR migrates all of the bindings that were touched by #136632, plus `LLVMDIBuilderCreateStructType`.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 18, 2025
cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4) - Part of rust-lang#134001 - Follow-up to rust-lang#146631 --- This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs.
rust-timer
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup merge of #146673 - Zalathar:di-builder, r=nnethercote cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4) - Part of #134001 - Follow-up to #146631 --- This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cg_llvmdebuginfo handling to use the LLVM-C API #134001This is another batch of LLVMDIBuilder binding migrations, replacing some our own LLVMRust bindings with bindings to upstream LLVM-C APIs.
This PR migrates all of the bindings that were touched by #136632, plus
LLVMDIBuilderCreateStructType.