Skip to content

Conversation

fmease
Copy link
Member

@fmease fmease commented Sep 12, 2025

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 12, 2025
@fmease
Copy link
Member Author

fmease commented Sep 12, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 12, 2025
[perf] rustdoc: Don't obtain early resolver unless `--generate-macro-expansion`
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 12, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 12, 2025

☀️ Try build successful (CI)
Build commit: 75de7a5 (75de7a5c8d627fa6a292a6908cf167a075bfb2f4, parent: a171994070dc18c3a32fc1aa2d98cf03ae96b63e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (75de7a5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [1.4%, 4.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.518s -> 469.283s (-0.05%)
Artifact size: 388.08 MiB -> 388.08 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 12, 2025
@fmease fmease changed the title [perf] rustdoc: Don't obtain early resolver unless --generate-macro-expansion [perf] rustdoc Sep 12, 2025
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend labels Sep 13, 2025
@fmease
Copy link
Member Author

fmease commented Sep 13, 2025

@bors try parent=last @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 13, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 13, 2025

☀️ Try build successful (CI)
Build commit: d31c481 (d31c4814955e9a0317f3f68be21e7b3989fd216f, parent: a171994070dc18c3a32fc1aa2d98cf03ae96b63e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d31c481): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-6.1%, -0.2%] 19
Improvements ✅
(secondary)
-4.4% [-14.1%, -0.2%] 12
All ❌✅ (primary) -1.3% [-6.1%, -0.2%] 19

Max RSS (memory usage)

Results (primary -3.2%, secondary -6.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)
-3.2% [-4.5%, -2.3%] 5
Improvements ✅
(secondary)
-8.4% [-18.5%, -1.7%] 6
All ❌✅ (primary) -3.2% [-4.5%, -2.3%] 5

Cycles

Results (primary -3.8%, secondary -13.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.8% [-5.1%, -3.1%] 3
Improvements ✅
(secondary)
-13.6% [-24.9%, -3.6%] 5
All ❌✅ (primary) -3.8% [-5.1%, -3.1%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.518s -> 468.868s (-0.14%)
Artifact size: 388.08 MiB -> 387.99 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease force-pushed the rustdoc-gen-mac-exp-perf-fix branch from abca022 to b204031 Compare September 13, 2025 16:59
@fmease
Copy link
Member Author

fmease commented Sep 13, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Sep 13, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@rust-bors
Copy link

rust-bors bot commented Sep 13, 2025

☀️ Try build successful (CI)
Build commit: 44e9f49 (44e9f49327b4f9a72231cc3491d243e6a5b4d348, parent: b50f345a2f3f49764024cabc30ef99e15c0240f7)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (44e9f49): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [2.6%, 5.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.3% [2.2%, 10.5%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.696s -> 471.555s (-0.03%)
Artifact size: 390.21 MiB -> 390.24 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2025
@fmease fmease changed the title [perf] rustdoc Perf experiments Sep 15, 2025
@fmease fmease removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-json Area: Rustdoc JSON backend A-run-make Area: port run-make Makefiles to rmake.rs T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants