Skip to content

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Sep 10, 2025

Fixes #145988.
Fixes #146163.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

⚠️ Warning ⚠️

@dianqk
Copy link
Member

dianqk commented Sep 10, 2025

Thanks!
@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Sep 10, 2025

📌 Commit 092d653 has been approved by dianqk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
@dianqk dianqk assigned dianqk and unassigned cuviper Sep 10, 2025
@nikic
Copy link
Contributor Author

nikic commented Sep 10, 2025

@bors p=1 Fixes P-critical and should land before beta promotion.

bors added a commit that referenced this pull request Sep 10, 2025
@bors
Copy link
Collaborator

bors commented Sep 10, 2025

⌛ Testing commit 092d653 with merge a68b5b4...

@bors
Copy link
Collaborator

bors commented Sep 10, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 10, 2025
@nikic
Copy link
Contributor Author

nikic commented Sep 10, 2025

@bors retry network error

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025
@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
spellcheck files
building external tool typos from package [email protected]
finished building tool typos
npm WARN deprecated [email protected]: < 24.10.2 is no longer supported
npm ERR! code ECONNRESET
npm ERR! errno ECONNRESET
npm ERR! network Invalid response body while trying to fetch https://registry.npmjs.org/typescript: aborted
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-09-10T15_06_31_901Z-debug-0.log
npm install did not exit successfully
some tidy checks failed
tidy error: IO error: npm install returned exit code exit status: 1
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1550:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1281:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:02:56
  local time: Wed Sep 10 15:07:12 UTC 2025
  network time: Wed, 10 Sep 2025 15:07:12 GMT
##[error]Process completed with exit code 1.

@dianqk
Copy link
Member

dianqk commented Sep 10, 2025

@bors retry

bors added a commit that referenced this pull request Sep 11, 2025
@bors
Copy link
Collaborator

bors commented Sep 11, 2025

⌛ Testing commit 092d653 with merge 1695eeb...

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2025
@Zalathar
Copy link
Contributor

@bors retry (runner flaked out again)

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 11, 2025
@bors
Copy link
Collaborator

bors commented Sep 11, 2025

⌛ Testing commit 092d653 with merge 5e33838...

@bors
Copy link
Collaborator

bors commented Sep 11, 2025

☀️ Test successful - checks-actions
Approved by: dianqk
Pushing 5e33838 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2025
@bors bors merged commit 5e33838 into rust-lang:master Sep 11, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 11, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f4665ab (parent) -> 5e33838 (this PR)

Test differences

Show 10 test diffs

Stage 2

  • [assembly] tests/assembly-llvm/nvptx-safe-naming.rs#LLVM20: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 20) (J0)
  • [assembly] tests/assembly-llvm/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 19) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen-llvm/enum/enum-discriminant-eq.rs#LLVM20: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 20) (J0)
  • [codegen] tests/codegen-llvm/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 19) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 19) (J0)
  • [assembly] tests/assembly-llvm/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 19) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 19) (J1)
  • [assembly] tests/assembly-llvm/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 19) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 19) (J1)
  • [ui] tests/ui/sanitizer/kcfi-arity-requires-llvm-21-0-0.rs: ignore (ignored when the LLVM version (21.1.0) is newer than majorversion 20) -> ignore (ignored when the LLVM version (21.1.1) is newer than majorversion 20) (J2)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J3)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5e33838ccad070f1536ed82336dd0133e2681233 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1487.4s -> 2040.0s (37.2%)
  2. x86_64-rust-for-linux: 2757.0s -> 3661.7s (32.8%)
  3. x86_64-gnu-tools: 3404.0s -> 4453.9s (30.8%)
  4. dist-aarch64-linux: 8865.9s -> 6286.2s (-29.1%)
  5. pr-check-2: 2298.8s -> 2799.8s (21.8%)
  6. test-various: 4601.5s -> 5404.7s (17.5%)
  7. armhf-gnu: 5022.3s -> 5845.5s (16.4%)
  8. x86_64-gnu: 7028.7s -> 8040.7s (14.4%)
  9. arm-android: 6072.5s -> 6930.0s (14.1%)
  10. x86_64-gnu-nopt: 7339.0s -> 8356.7s (13.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5e33838): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.6%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
4.4% [2.5%, 5.4%] 10
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.2%, -2.4%] 2
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [0.9%, 3.1%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.319s -> 468.387s (0.01%)
Artifact size: 387.51 MiB -> 387.81 MiB (0.08%)

@dianqk dianqk added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 12, 2025
@dianqk
Copy link
Member

dianqk commented Sep 12, 2025

landed before the beta, no nomination needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscomputation error on nightly starting with 2025-08-11 rustc hangs with release build since the llvm 21 merge on crate not on crates.io
8 participants