Convert `no_std` and `no_core` to the new attribute infrastructure #146389

jdonszelmann · 2025-09-09T22:52:50Z

Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

rustbot · 2025-09-09T22:52:54Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2025-09-09T22:52:56Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

fee1-dead · 2025-09-09T23:27:44Z

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

+    // FIXME: recursion limit is allowed on all targets and ignored,
+    //        even though it should only be valid on crates of course
+    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowList(ALL_TARGETS);


Interesting. Why aren't we turning this into a future incompat warning?

it already sort of is. I'm refactoring this as we speak

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

oli-obk

Where is the previous logic for doing sanity checks on these attrs?

Should we crater this in case there are some commonly used macros doing sth weird that gets silenced or sth?

View changes since this review

oli-obk · 2025-09-10T09:28:00Z

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

+impl<S: Stage> NoArgsAttributeParser<S> for NoCoreParser {
+    const PATH: &[Symbol] = &[sym::no_core];
+    const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::Warn;
+    // FIXME: recursion limit is allowed on all targets and ignored,


Copy pasta from #[recursion_limit]

jdonszelmann · 2025-09-10T17:59:54Z

the previous logic is part of template checking. Since these were such simple attrs, there barely was any. In fact, in many places, to be backwards compatible we don't even use these parsers, we simply check for the attr name in the ast attrs. However, having a parser for them is still valuable since it gives us a new place to put the template (we want to move them all over some day) and it guarantees we don't miss parsing any of them. It also improves diagnostics. The old validation code is shared between all attributes and is still there until all attributes are converted. That codepath is not run anymore, validation now only happens here. Switching these codepaths is automatic when a new-style parser is added hence there's no specific code for that. This change also makes it so downstream we do get these attrs as parsed, hence the fact that clipyp does use it instead of matching on ast (symbol) attrs

jdonszelmann · 2025-09-10T18:06:42Z

@rustbot review

oli-obk · 2025-09-10T18:15:03Z

@bors r+ rollup

bors · 2025-09-10T18:15:06Z

📌 Commit e48203f has been approved by oli-obk

It is now in the queue for this repository.

jdonszelmann · 2025-09-10T18:47:34Z

@bors r-

jdonszelmann · 2025-09-10T18:48:11Z

@oli-obk CI never passed lol. I fixed some tests (only diag improvements) just now. Once it does I'll r=you

jdonszelmann · 2025-09-10T19:56:18Z

@bors r=oli-obk

bors · 2025-09-10T19:56:20Z

📌 Commit dbd3ef1 has been approved by oli-obk

It is now in the queue for this repository.

Rollup of 16 pull requests Successful merges: - #145660 (initial implementation of the darwin_objc unstable feature) - #145895 (thread parking: fix docs and examples) - #146308 (support integer literals in `${concat()}`) - #146323 (check before test for hardware capabilites in bits 32~63 of usize) - #146332 (tidy: make behavior of extra-checks more uniform) - #146338 (Extends AArch64 branch protection support to include GCS) - #146374 (Update `browser-ui-test` version to `0.22.2`) - #146413 (Improve suggestion in case a bare URL is surrounded by brackets) - #146426 (Bump miow to 0.60.1) - #146432 (Implement `Socket::take_error` for Hermit) - #146433 (rwlock tests: fix miri macos test regression) - #146435 (Change the default value of `gcc.download-ci-gcc` to `true`) - #146439 (fix cfg for poison test macro) - #146448 ([rustdoc] Correctly handle literal search on paths) - #146449 (Fix `libgccjit` symlink when we build GCC locally) - #146455 (test: remove an outdated normalization for rustc versions) Failed merges: - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Convert `no_std` and `no_core` to the new attribute infrastructure r? ``@oli-obk`` Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

Rollup of 4 pull requests Successful merges: - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure) - #146452 (Improve `alloc::Layout` coverage) - #146473 (Revert "Constify SystemTime methods") - #146477 (Improve `core::char` coverage) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 5 pull requests Successful merges: - #146389 (Convert `no_std` and `no_core` to the new attribute infrastructure) - #146403 (sort array trait implementation suggestions correctly) - #146452 (Improve `alloc::Layout` coverage) - #146477 (Improve `core::char` coverage) - #146481 (Improve `core::hash` coverage) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146389 - jdonszelmann:no-std, r=oli-obk Convert `no_std` and `no_core` to the new attribute infrastructure r? ```@oli-obk``` Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

…, r=scrabsha Crate level into allowed targets r? `@scrabsha` `@rustbot` blocked on #146389

Convert `no_std` and `no_core` to the new attribute infrastructure r? ```@oli-obk``` Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

jdonszelmann added 2 commits September 9, 2025 15:16

port #[no_core] to the new attribute parsing infrastructure

b262cae

port #[no_std] to the new attribute parsing infrastructure

0db2eb7

rustbot assigned oli-obk Sep 9, 2025

fee1-dead reviewed Sep 9, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

fbstj reviewed Sep 10, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/crate_level.rs Show resolved Hide resolved

oli-obk requested changes Sep 10, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

jdonszelmann force-pushed the no-std branch from 407f45c to e48203f Compare September 10, 2025 18:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

This comment has been minimized.

Sign in to view

fixup no_{core,std} handling code

dbd3ef1

jdonszelmann force-pushed the no-std branch from e48203f to dbd3ef1 Compare September 10, 2025 18:45

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 10, 2025

jdonszelmann mentioned this pull request Sep 10, 2025

Crate level into allowed targets #146420

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025

Zalathar mentioned this pull request Sep 12, 2025

Rollup of 16 pull requests #146461

Closed

jdonszelmann mentioned this pull request Sep 12, 2025

Rollup of 4 pull requests #146492

Closed

jdonszelmann mentioned this pull request Sep 13, 2025

Rollup of 5 pull requests #146494

Merged

bors merged commit 147e97a into rust-lang:master Sep 13, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 13, 2025

bors added a commit that referenced this pull request Sep 14, 2025

Auto merge of #146420 - jdonszelmann:crate-level-into-allowed-targets…

ddaf123

…, r=scrabsha Crate level into allowed targets r? `@scrabsha` `@rustbot` blocked on #146389

github-actions bot mentioned this pull request Sep 12, 2025

Toolchain upgrade to nightly-2025-09-18 flux-rs/flux#1271

Draft

jdonszelmann mentioned this pull request Sep 18, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

Convert no_std and no_core to the new attribute infrastructure #146389

Convert no_std and no_core to the new attribute infrastructure #146389

Uh oh!

Conversation

jdonszelmann commented Sep 9, 2025

Uh oh!

rustbot commented Sep 9, 2025

Uh oh!

rustbot commented Sep 9, 2025

Uh oh!

fee1-dead Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oli-obk Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Sep 10, 2025

Uh oh!

jdonszelmann commented Sep 10, 2025

Uh oh!

oli-obk commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

This comment has been minimized.

jdonszelmann commented Sep 10, 2025

Uh oh!

jdonszelmann commented Sep 10, 2025

Uh oh!

jdonszelmann commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Convert `no_std` and `no_core` to the new attribute infrastructure #146389

Convert `no_std` and `no_core` to the new attribute infrastructure #146389

oli-obk left a comment •

edited by rustbot

Loading