-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Implement raw-dylib
on Mach-O
#146357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
madsmtm
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
madsmtm:macho-raw-dylib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement raw-dylib
on Mach-O
#146357
+465
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #146636) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-attributes
Area: Attributes (`#[…]`, `#![…]`)
A-linkage
Area: linking into static, shared libraries and binaries
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
F-raw_dylib
`#![feature(raw_dylib)]`
O-apple
Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS)
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #146356 by adding the
raw_dylib_macho
feature flag.@Noratrieb sniped me at RustWeek few months back to investigate this, never got around to finishing it.
This is a draft because I found out (after being 80% done with the impl) that using LLVM's TextAPI is probably not going to fly if we want to support other codegen backends, we'll need to write
.tbd
stubs ourselves.TODO:
object
.r? bjorn3
CC @Noratrieb @thomcc @roblabla