Skip to content

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 7, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

yotamofek and others added 4 commits September 5, 2025 18:43
This reverts commit 5b43244 to fix
native build failures on LoongArch.
…alue, r=cjgillot

Use `Itertools::all_equal_value()` where applicable

Just a small cleanup.
We already have `itertools` as a dep in these crates, so might as well use another of its features.
Makes the code simpler IMHO :)
Revert "Add LSX accelerated implementation for source file analysis"

This reverts commit 5b43244 to fix native build failures on LoongArch.

Link: rust-lang#145963 (comment)
Link: rust-lang#145963 (comment)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 7, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 1b492b0 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@bors
Copy link
Collaborator

bors commented Sep 7, 2025

⌛ Testing commit 1b492b0 with merge fbd8f95...

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing fbd8f95 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2025
@bors bors merged commit fbd8f95 into rust-lang:master Sep 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146254 Use Itertools::all_equal_value() where applicable 2e45bed8eed8e3c4daa33b94b1ef6b0ff1b88a2a (link)
#146290 Revert "Add LSX accelerated implementation for source file … 12cced7dce721a685bcb06668f4746d824444076 (link)

previous master: ebdf2abea4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

github-actions bot commented Sep 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ebdf2ab (parent) -> fbd8f95 (this PR)

Test differences

Show 26 test diffs

26 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fbd8f95118fff54a2402983d3f446cad9b2f30c5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3049.5s -> 4023.8s (31.9%)
  2. pr-check-1: 1351.8s -> 1695.9s (25.5%)
  3. x86_64-gnu-llvm-19: 2374.7s -> 2920.1s (23.0%)
  4. x86_64-rust-for-linux: 2568.3s -> 3035.7s (18.2%)
  5. i686-gnu-2: 5401.1s -> 6229.9s (15.3%)
  6. x86_64-gnu-llvm-19-1: 3269.4s -> 3647.1s (11.6%)
  7. i686-gnu-1: 7707.2s -> 8556.5s (11.0%)
  8. aarch64-gnu-llvm-19-2: 2194.5s -> 2420.3s (10.3%)
  9. aarch64-msvc-2: 5293.8s -> 4788.3s (-9.5%)
  10. armhf-gnu: 4760.8s -> 5206.4s (9.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fbd8f95): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

Results (secondary -5.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.9% [-5.9%, -5.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.99s -> 467.216s (-0.17%)
Artifact size: 387.45 MiB -> 387.43 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants