Skip to content

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Sep 6, 2025

Related to #138511. To call Parser::parse_expr_cond from rustfmt forks for custom macro formatting you need to pass this enum so it would be nice if it could be public.

Thank you.

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 6, 2025
@lqd
Copy link
Member

lqd commented Sep 6, 2025

👍

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 6, 2025

📌 Commit 7fada16 has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned jieyouxu Sep 6, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2025
bors added a commit that referenced this pull request Sep 6, 2025
Rollup of 5 pull requests

Successful merges:

 - #139524 (Add socket extensions for cygwin)
 - #145940 (single buffer for exponent fmt of integers)
 - #146206 (identity uses are ok, even if there are no defining uses)
 - #146272 (Update comment for `-Werror` on LLVM builds)
 - #146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f338542 into rust-lang:master Sep 7, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 7, 2025
Rollup merge of #146280 - mohe2015:public-for-rustfmt-forks, r=lqd

Make `LetChainsPolicy` public for rustfmt usage

Related to #138511. To call `Parser::parse_expr_cond` from [rustfmt forks for custom macro formatting](https://github.com/tucant/rustfmt/blob/30c83df9e1db10007bdd16dafce8a86b404329b2/src/parse/macros/html.rs#L57) you need to pass this enum so it would be nice if it could be public.

Thank you.
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Sep 8, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#139524 (Add socket extensions for cygwin)
 - rust-lang/rust#145940 (single buffer for exponent fmt of integers)
 - rust-lang/rust#146206 (identity uses are ok, even if there are no defining uses)
 - rust-lang/rust#146272 (Update comment for `-Werror` on LLVM builds)
 - rust-lang/rust#146280 (Make `LetChainsPolicy` public for rustfmt usage)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants