alloc: make Cow From impls const #146067
Closed
alloc: make Cow From impls const #146067
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
oli-obk
reviewed
Sep 1, 2025
| @@ -245,7 +245,8 @@ impl<'a> From<&'a ByteStr> for ByteString { | |||
| } | |||
|
|
|||
| #[unstable(feature = "bstr", issue = "134915")] | |||
| impl<'a> From<ByteString> for Cow<'a, ByteStr> { | |||
| #[rustc_const_unstable(feature = "const_from", issue = "143773")] | |||
| impl<'a> const From<ByteString> for Cow<'a, ByteStr> { | |||
There was a problem hiding this comment.
Do we have the equivalent for String? And is ByteString const constructible
There was a problem hiding this comment.
@oli-obk Yes, the equivalent for String is in this same patch.
ByteString is const constructible:
#[repr(transparent)]
pub struct ByteString(pub Vec<u8>);Both Vec and String are const constructible:
https://doc.rust-lang.org/std/vec/struct.Vec.html#method.new
https://doc.rust-lang.org/std/string/struct.String.html#method.new
There was a problem hiding this comment.
Oh lol i stopped scrolling and didnt see the other files
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 1, 2025
alloc: make Cow From impls const This is an expansion of rust-lang#143773 for the `Cow` `From` conversions. r? `@oli-obk`
bors
added a commit
that referenced
this pull request
Sep 2, 2025
Rollup of 10 pull requests Successful merges: - #144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs) - #145783 (add span to struct pattern rest (..)) - #145961 (resolve: Avoid a regression from splitting prelude into two scopes) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #146064 (Add compiler error when trying to use concat metavar expr in repetitions) - #146067 (alloc: make Cow From impls const) - #146070 (rustdoc-search: skip loading unneeded fnData) - #146089 (fix a constness ordering bug in rustfmt) - #146094 (Make `Parser::parse_for_head` public for rustfmt usage) - #146102 (Remove dead code stemming from an old effects desugaring) r? `@ghost` `@rustbot` modify labels: rollup
|
Does anyone read the tracking issues any more? Whatever. I explicitly had this as part of #144289 and was not including it because the other reviewer, @tgross35, expressed apprehension about adding heap-allocated trait impls at the end. Part of this PR exists as #145279, which you would find out if you read the comments on the tracking issue you linked. |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 2, 2025
alloc: make Cow From impls const This is an expansion of rust-lang#143773 for the `Cow` `From` conversions. r? `@oli-obk`
bors
added a commit
that referenced
this pull request
Sep 2, 2025
Rollup of 9 pull requests Successful merges: - #145783 (add span to struct pattern rest (..)) - #145961 (resolve: Avoid a regression from splitting prelude into two scopes) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #146064 (Add compiler error when trying to use concat metavar expr in repetitions) - #146067 (alloc: make Cow From impls const) - #146070 (rustdoc-search: skip loading unneeded fnData) - #146089 (fix a constness ordering bug in rustfmt) - #146094 (Make `Parser::parse_for_head` public for rustfmt usage) - #146102 (Remove dead code stemming from an old effects desugaring) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors r- |
bors
added
S-waiting-on-author
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expansion of #143773 for the
CowFromconversions.r? @oli-obk