str: Stabilize round_char_boundary feature
#145756
Conversation
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
| @@ -51,7 +51,6 @@ | |||
| #![feature(negative_impls)] | |||
| #![feature(never_type)] | |||
| #![feature(ptr_alignment_type)] | |||
| #![feature(round_char_boundary)] | |||
There was a problem hiding this comment.
Won't you need to cfg_attr(bootstrap, …) the feature in the compiler itself (two instances)?
There was a problem hiding this comment.
You'll need to do this in Clippy's clippy_lints crate as well, since it can now be built by the stage0 compiler.
There was a problem hiding this comment.
Thanks, I haven't stabilized a feature that touched these other parts of the compiler before.
I manually reordered the cfg_attr features because tidy check complained about alphabetic ordering, but it didn't suggest what line to place it. I couldn't find an automatic --fix option either. Running ./x fmt didn't seem to adjust it either but maybe I have the setup configured wrong (I have it set to the library contributing mode, not sure if that changes anything).
There was a problem hiding this comment.
x fmt doesn't reorder AFAICT, you have to put the inner attributes in order by hand (as you did).
Clippy using stage 0 is new and doesn't care about inner attributes order, what you did (order by feature name) is fine as well there.
| @@ -1,4 +1,3 @@ | |||
| #![feature(round_char_boundary)] | |||
There was a problem hiding this comment.
You need to run ./x.py test clippy --bless to update the stderr file with the line number changes.
There was a problem hiding this comment.
Addressed in c5c6520
okaneco
force-pushed
the
stabilize_char_boundary
branch
from
214dcea to
c5c6520
Compare
This comment has been minimized.
This comment has been minimized.
okaneco
force-pushed
the
stabilize_char_boundary
branch
from
c5c6520 to
e42c1b1
Compare
Closes #93743
FCP completed #93743 (comment)