-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Introduce a [workspace.dependencies
] section in the top-level Cargo.toml
#145740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt
cc @davidtwco, @compiler-errors, @TaKO8Ki This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in src/tools/clippy cc @rust-lang/clippy The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in compiler/rustc_sanitizers cc @rcvalle |
ec2ac7a
to
c7f79dc
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
@@ -41,7 +41,7 @@ serde_json = "1.0.122" | |||
toml = "0.7.3" | |||
walkdir = "2.3" | |||
filetime = "0.2.9" | |||
itertools = "0.12" | |||
itertools.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would that work in the standalone Clippy repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it won't. Likewise for other parts done in separate repositories: rustfmt, miri, anything else. That's annoying :/
@@ -5,7 +5,7 @@ edition = "2024" | |||
|
|||
[dependencies] | |||
# tidy-alphabetical-start | |||
bitflags = "2.4.1" | |||
bitflags.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason why choosing
bitflags.workspace = true
syntax over
bitflags = { workspace = true }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not author, but it hurts me eyes less... do you prefer the other form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bitflags = { } syntax is used a lot for other things. For me it's more consistent :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's shorter, that's all.
It lets us avoid a lot of repetition of crate versions, etc.
I've just done a few as a start. Many more can be done in follow-ups.
r? @Kobzol