-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Enforce in bootstrap that test must have stage at least 1 (except for compiletest) #145663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kobzol
wants to merge
23
commits into
rust-lang:master
Choose a base branch
from
Kobzol:bootstrap-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a3ef817
Add snapshot test for `tier-check`
Kobzol 65b7cde
Fixup `x test tier-check`
Kobzol 542e750
Forbid running tests on stage 0 unless `build.compiletest-allow-stage…
Kobzol f0d15d3
Add snapshot test for `x test`
Kobzol a347f8d
Fix staging of `TestFloatParse`
Kobzol 42fb65b
Remove `compiler_for` from `test::CodegenGCC`
Kobzol 2ca5cb8
Remove `compiler_for` from `test::CodegenCranelift`
Kobzol e759b97
Refactor `test::LintDocs`
Kobzol 0f2fc03
Remove stage0 checking
Kobzol 1d96ef8
Small refactoring around `RemoteCopyLibs`
Kobzol 384a044
Add metadata to a bunch of steps, rename variables and add comments
Kobzol 6651686
Move the `test!` macro closer to its usages
Kobzol 0b3a13c
Fix staging for compiler/std crate tests
Kobzol ef569d3
Fix spacing when testing individual crates
Kobzol dda8e1d
Do not run tests on CI in stage 0
Kobzol b53d532
Add change tracker entry
Kobzol 425c66e
Skip bootstrap tests on CI
Kobzol 1591901
Fix doclink
Kobzol 1c1d630
Fake nodejs in snapshot test
Kobzol daaf0c9
Fix tests and doclink
Kobzol d2195c4
Add test stage 2 snapshot tests
Kobzol 9de09ac
Fix stage 1 compiler tests
Kobzol 5bc9308
Do not run `lint-docs` tests in stage 1 `x test` by default
Kobzol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is this because we run doctests on
rustc_lint_defs
with a build compiler, which could be a stage 0 rustc which happens to be a beta rustc?Would this be broken under
local-rebuild
if the build compiler happens to be the in-tree compiler that e.g. would know aboutfeature(sanitize)
? Or is that not a supported configuration for this particular case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think that we can remove this now, because in the latest commit I skipped the
lint-docs
tests in stage 1, and running them with explicit--stage 1
runs into other failures anyway. I'll try to remove it and see what CI says.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay. Because this dual gating was a bit surprising to see.