std_detect: RISC-V: implement implication to "C" #145415
Open
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like we implemented relatively complex rules to imply other extensions **from** "C" (and some others), this commit implements implication **to** the "C" extension from others, complying the following text in the ISA Manual (although there's no direct imply/depend references). > The C extension is the superset of the following extensions: > > - Zca > - Zcf if F is specified (RV32 only) > - Zcd if D is specified This is formally proven so that no other extension combinations (*not* in this implementation) can (currently) imply the "C" extension.
rustbot
added
S-waiting-on-review
|
Looks like we should see the situation of #145489 (if that PR is merged, it's better to substitute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we implemented relatively complex rules to imply other extensions from "C" (and some others), this commit implements implication to the "C" extension from others, complying the following text in the ISA Manual (although there's no direct imply/depend references).
This is formally proven so that no other extension combinations (not in this implementation) can (currently) imply the "C" extension.
Note: this is a
std_detectchange and not main target feature handling.Actual Formal Proof:
riscv-c-implications.pyr? @Amanieu
@rustbot label +O-riscv