-
Notifications
You must be signed in to change notification settings - Fork 13.7k
strip prefix of temporary file names when it exceeds filesystem name length limit #145005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// This file has very long lines, but there is no way to avoid it as we are testing | ||
// long crate names. so: | ||
// ignore-tidy-linelength | ||
|
||
extern crate generated_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_crate_name; | ||
|
||
fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// This file has very long lines, but there is no way to avoid it as we are testing | ||
// long crate names. so: | ||
// ignore-tidy-linelength | ||
|
||
// A variant of the smoke test to check that link time optimization | ||
// (LTO) is accepted by the compiler, and that | ||
// passing its various flags still results in successful compilation, even for very long crate names. | ||
// See https://github.com/rust-lang/rust/issues/49914 | ||
|
||
//@ ignore-cross-compile | ||
|
||
use std::fs; | ||
|
||
use run_make_support::{rfs, rustc}; | ||
|
||
// This test make sure we don't get such following error: | ||
// error: could not write output to generated_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_crate_name.generated_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_crate_name.9384edb61bfd127c-cgu.0.rcgu.o: File name too long | ||
// as reported in issue #49914 | ||
fn main() { | ||
let lto_flags = ["-Clto", "-Clto=yes", "-Clto=off", "-Clto=thin", "-Clto=fat"]; | ||
let aux_file = "generated_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_large_crate_name.rs"; | ||
// The auxiliary file is used to test long crate names. | ||
// The file name is intentionally long to test the handling of long filenames. | ||
// We don't commit it to avoid issues with Windows paths which have known limitations for the full path length. | ||
// Posix usually only have a limit for the length of the file name. | ||
rfs::write(aux_file, "#![crate_type = \"rlib\"]\n"); | ||
|
||
for flag in lto_flags { | ||
rustc().input(aux_file).arg(flag).run(); | ||
rustc().input("main.rs").arg(flag).run(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start of the filename has more useful information, but we do absolutely need to preserve file extensions (plural: eg
.rcgu.o
) for correctness and it isn't trivial to distinguish between file extensions and normal dot separated filename components. So I guess the current implementation is good enough.