- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
[test][run-make] add needs-llvm-components #144668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 1 commit into
  rust-lang:master
from
daltenty:daltenty/runmake-llvm-components
  
      
      
   
  Jul 30, 2025 
      
    
                
     Merged
            
            [test][run-make] add needs-llvm-components #144668
                    bors
  merged 1 commit into
  rust-lang:master
from
daltenty:daltenty/runmake-llvm-components
  
      
      
   
  Jul 30, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Add some constraints to run-make tests that require specific target support and will fail without them.
| 
 | 
| This PR modifies  cc @jieyouxu | 
              
                    jieyouxu
  
              
              approved these changes
              
                  
                    Jul 30, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
| @bors r+ rollup | 
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Jul 30, 2025 
    
    
      
  
    
      
    
  
Rollup of 6 pull requests Successful merges: - #144042 (Verify llvm-needs-components are not empty and match the --target value) - #144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`) - #144411 (Remove `hello_world` directory) - #144662 (compiletest: Move directive names back into a separate file) - #144666 (Make sure to account for the right item universal regions in borrowck) - #144668 ([test][run-make] add needs-llvm-components) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Jul 30, 2025 
    
    
      
  
    
      
    
  
Rollup merge of #144668 - daltenty:daltenty/runmake-llvm-components, r=jieyouxu [test][run-make] add needs-llvm-components Add some constraints to run-make tests that require specific target support and will fail without them.
    
  github-actions bot
      pushed a commit
        to rust-lang/rustc-dev-guide
      that referenced
      this pull request
    
      Jul 31, 2025 
    
    
      
  
    
      
    
  
Rollup of 6 pull requests Successful merges: - rust-lang/rust#144042 (Verify llvm-needs-components are not empty and match the --target value) - rust-lang/rust#144268 (Add method `find_ancestor_not_from_macro` and `find_ancestor_not_from_extern_macro` to supersede `find_oldest_ancestor_in_same_ctxt`) - rust-lang/rust#144411 (Remove `hello_world` directory) - rust-lang/rust#144662 (compiletest: Move directive names back into a separate file) - rust-lang/rust#144666 (Make sure to account for the right item universal regions in borrowck) - rust-lang/rust#144668 ([test][run-make] add needs-llvm-components) r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-run-make
  Area: port run-make Makefiles to rmake.rs 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Add some constraints to run-make tests that require specific target support and will fail without them.